[AIRFLOW-3864] Recognize lists as JSON in variables --import

[samdfonseca]

Make sure you have checked all steps below.

Jira

• My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
  • https://issues.apache.org/jira/browse/AIRFLOW-3864
  • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.

Description

• Here are some details about my PR, including screenshots of any UI changes:
  • When settings a variable via import, sets serialize_json=True if its value is a list

Tests

• My PR adds the following unit tests OR does not need testing for this extremely good reason:
  • There doesn't seem to be support currently for cli tests

Commits

• My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
  1. Subject is separated from body by a blank line
  2. Subject is limited to 50 characters (not including Jira issue reference)
  3. Subject does not end with a period
  4. Subject uses the imperative mood ("add", not "adding")
  5. Body wraps at 72 characters
  6. Body explains "what" and "why", not "how"

Documentation

• In case of new functionality, my PR adds documentation that describes how to use it.
  • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
  • All the public functions and the classes in the PR contain docstrings that explain what it does

Code Quality

• Passes flake8

[codecov-io]

Codecov Report

Merging #4686 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4686      +/-   ##
==========================================
+ Coverage   74.35%   74.35%   +<.01%     
==========================================
  Files         430      430              
  Lines       27962    27962              
==========================================
+ Hits        20790    20791       +1     
+ Misses       7172     7171       -1

Impacted Files	Coverage Δ
airflow/bin/cli.py	67.22% <100%> (ø)	⬆️
airflow/models/__init__.py	92.79% <0%> (+0.05%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59d2615...725f86a. Read the comment docs.

[zhongjiajie]

LGTM

[samdfonseca]

@zhongjiajie thanks for the review. Anything you need from me to get this merged?

[OmerJog]

Is this related to https://issues.apache.org/jira/browse/AIRFLOW-2141 ?

[zhongjiajie]

@samdfonseca Sorry, I not a committer, you could at some committer to review and merge your PR, like @Fokko @ashb PTAL thanks.
BTY, welcome to Apache Airflow

[zhongjiajie]

@OmerJog Yes, I think is related to that jira ticket, do you think we should use

if not isinstance(v, str):
    Variable.set(k, v, serialize_json=True)

[ashb]

Could you please add some tests to this - there is a case already in tests/core.py - CliTest.test_variables. You'll probably just have to extend the file it imports and add a new assertion or two

[ashb]

Please add unit tests

[ashb]

Please target against AIRFLOW-2141 instead.

[kaxil]

Closed in favor of #4991