[EDGE]Fix maintenance states during shut down#46861
Merged
jscheffl merged 4 commits intoapache:mainfrom Feb 18, 2025
Merged
Conversation
boring-cyborg
bot
added
the
provider:edge
jscheffl
approved these changes
Feb 18, 2025
ntr
pushed a commit
to ntr/airflow
that referenced
this pull request
Feb 20, 2025
* fix states during shut down * Modify state machine * add more tests * fix static checks --------- Co-authored-by: Majoros Donat (XC-DX/EET2-Bp) <donat.majoros2@hu.bosch.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a worker is registered, and it was in offline maintenance, we set the state to maintenance request. However, this has a side effect. During graceful shut down we set the state to offline maintenance, and if we are not lucky, the heartbeat is called again, which will set the state to maintenance request from offline maintenance during shut down.
Solution: Only modify offline maintenance to maintenance request if the worker is starting up
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.