AIP-38 Allow specifiying injectable server url#46900
Merged
pierrejeambrun merged 4 commits intoapache:mainfrom Feb 21, 2025
Merged
AIP-38 Allow specifiying injectable server url#46900pierrejeambrun merged 4 commits intoapache:mainfrom
pierrejeambrun merged 4 commits intoapache:mainfrom
Conversation
pierrejeambrun
requested review from
bbovenzi,
jscheffl and
ryanahamilton
as code owners
ashb
reviewed
Feb 19, 2025
ianbuss
reviewed
Feb 20, 2025
Member
Author
|
Need to fix the |
pierrejeambrun
commented
Feb 21, 2025
Member
Author
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
As other endpoint, config is not fetched from the appropriate endpoint.
It behaved differently because it's used in a pre-loader.
pierrejeambrun
force-pushed
the
46550-injectable-server-url
branch
from
3cc8bb7 to
14b990e
Compare
ashb
approved these changes
Feb 21, 2025
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
* AIP-38 Allow specifiying injectable server url * Add templatable backend url from config * Fix CI * Move the base init logic to queryClient so the config loader uses the appropriate endpoint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #46550
How to test
dev-modeon.fastapi.base_urlto your fastapi server (localhost:9091)export AIRFLOW__API__ACCESS_CONTROL_ALLOW_ORIGINS="http://localhost:29090"airflow fastapi-apiwith the (CORS env variable set in the previous step)http://localhost:29091/webapp/requests should go to your standalone fastapi server instead of the breeze one (9091 instead of 29091)