Use UUID for TaskInstanceHistory primary key#47015
Closed
ephraimbuddy wants to merge 5 commits intoapache:mainfrom
Closed
Use UUID for TaskInstanceHistory primary key#47015ephraimbuddy wants to merge 5 commits intoapache:mainfrom
ephraimbuddy wants to merge 5 commits intoapache:mainfrom
Conversation
boring-cyborg
bot
added
area:db-migrations
ephraimbuddy
force-pushed
the
update-tihistory-id
branch
from
a6f8f48 to
f20992e
Compare
This PR updates the TaskInstanceHistory table to use UUID for the primary key. The primary is tied to TaskInstance.id as foreignkey so whatever value in TaskInstnace.id is the value we would have as TaskInstanceHistory.id. Manually tested the upgrades by rerunning a task instance, and upgrading/downgrading with the data
ephraimbuddy
force-pushed
the
update-tihistory-id
branch
from
f20992e to
3700f2b
Compare
ephraimbuddy
added
the
area:task-execution-interface-aip72
bugraoz93
approved these changes
Feb 24, 2025
Contributor
bugraoz93
left a comment
bugraoz93
left a comment
There was a problem hiding this comment.
Looks good! It seems MySQL slowly disappearing :D
Member
|
This is superseded by #47065. |
github-project-automation
bot
moved this to Done
in AIP-72 - Task Execution Interface and SDK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the TaskInstanceHistory table to use UUID for the primary key. The primary is tied to TaskInstance.id as foreignkey so whatever value in TaskInstnace.id is the value we would have as TaskInstanceHistory.id.
Manually tested the upgrades by rerunning a task instance, and upgrading/downgrading with the data
Closes: #43437