Skip to content

add convert_env_vars_from_list_of_dicts on backwards_compat_converters#47050

Open
s21lee wants to merge 12 commits intoapache:mainfrom
s21lee:add-convert_env_vars_from_list_of_dicts
Open

add convert_env_vars_from_list_of_dicts on backwards_compat_converters#47050
s21lee wants to merge 12 commits intoapache:mainfrom
s21lee:add-convert_env_vars_from_list_of_dicts

Conversation

@s21lee
Copy link

@s21lee s21lee commented Feb 25, 2025

This modification was made with backward compatibility.
In the previous version, env_vars was passed as a list of dictionaries. However, in the current version, if it is not passed as a V1EnvVar type, it causes issues in other hooks and other components that use these variables.

To avoid this, I added the necessary code to convert the string dictionary list format into the V1EnvVar type.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Signed-off-by: s21.lee <s21.lee@samsung.com>
@boring-cyborg boring-cyborg bot added the provider:cncf-kubernetes Kubernetes (k8s) provider related issues label Feb 25, 2025
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 25, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk
Copy link
Member

potiuk commented Feb 25, 2025

I don't think we ever look at PRs that do not explain what they are for in the description. I think it's quite an important thing to explain your intent if you want reviewers to take a look at it @s21lee

@s21lee
Copy link
Author

s21lee commented Feb 26, 2025

I don't think we ever look at PRs that do not explain what they are for in the description. I think it's quite an important thing to explain your intent if you want reviewers to take a look at it @s21lee

Sorry for the lack of explanation—I had to create the PR in a hurry.

This modification was made with backward compatibility in mind.
In the previous version, env_vars was passed as a list of dictionaries. However, in the current version, if it is not passed as a V1EnvVar type, it causes issues in hooks and other components that use these variables.

To avoid this, I added the necessary code to convert the string dictionary list format into the V1EnvVar type.

@s21lee
Copy link
Author

s21lee commented Mar 10, 2025

Hi, @jedcunningham @hussein-awala
If you have a time, would you like to review it?
Thank you.

@s21lee
Copy link
Author

s21lee commented Apr 1, 2025

Hi, @jedcunningham @hussein-awala
I'm still waiting :)

@s21lee s21lee marked this pull request as draft May 23, 2025 00:13
@s21lee s21lee marked this pull request as ready for review May 23, 2025 00:13
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Jul 29, 2025
@github-actions github-actions bot removed the stale Stale PRs per the .github/workflows/stale.yml policy file label Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:cncf-kubernetes Kubernetes (k8s) provider related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants