add convert_env_vars_from_list_of_dicts on backwards_compat_converters#47050
add convert_env_vars_from_list_of_dicts on backwards_compat_converters#47050s21lee wants to merge 12 commits intoapache:mainfrom
Conversation
Signed-off-by: s21.lee <s21.lee@samsung.com>
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
|
I don't think we ever look at PRs that do not explain what they are for in the description. I think it's quite an important thing to explain your intent if you want reviewers to take a look at it @s21lee |
Sorry for the lack of explanation—I had to create the PR in a hurry. This modification was made with backward compatibility in mind. To avoid this, I added the necessary code to convert the string dictionary list format into the V1EnvVar type. |
Signed-off-by: s21.lee <s21.lee@samsung.com>
...rs/cncf/kubernetes/tests/unit/cncf/kubernetes/backcompat/test_backwards_compat_converters.py
Outdated
Show resolved
Hide resolved
…t/test_backwards_compat_converters.py
|
Hi, @jedcunningham @hussein-awala |
|
Hi, @jedcunningham @hussein-awala |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
This modification was made with backward compatibility.
In the previous version, env_vars was passed as a list of dictionaries. However, in the current version, if it is not passed as a V1EnvVar type, it causes issues in other hooks and other components that use these variables.
To avoid this, I added the necessary code to convert the string dictionary list format into the V1EnvVar type.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.