Skip to content

[Edge] Export ti.success and ti.finish metrics from edge worker#47063

Merged
jscheffl merged 9 commits intoapache:mainfrom
boschglobal:feature/edge-worker-export-additional-metrics
Feb 28, 2025
Merged

[Edge] Export ti.success and ti.finish metrics from edge worker#47063
jscheffl merged 9 commits intoapache:mainfrom
boschglobal:feature/edge-worker-export-additional-metrics

Conversation

@AutomationDev85
Copy link
Contributor

Overview

The Edge worker currently does not move metrics which are emitted during task execution to the main Airflow instance.
This is not so easy to implement, so this PR adds the emit of ti.start and ti.finish metric. Like the main application., but with queue label extension.

Details of changes:

  • Emit ti.start and ti.finish metric for the edge worker.
  • Metrics include the queue name as label.

@boring-cyborg boring-cyborg bot added the provider:edge Edge Executor / Worker (AIP-69) / edge3 label Feb 25, 2025
Copy link
Contributor

@bugraoz93 bugraoz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Could you please include some tests covering new lines?

@AutomationDev85 AutomationDev85 force-pushed the feature/edge-worker-export-additional-metrics branch from ea0eb2a to 9166d01 Compare February 27, 2025 13:31
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding stats to the edge worker!

@jscheffl jscheffl merged commit 647b39d into apache:main Feb 28, 2025
60 checks passed
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Apr 4, 2025
…he#47063)

* edge worker exports ti.start and ti.finish metrics

* Fixed wrong job fields during metric export

* Extend metric exporting

* Fix sql query

* Fix finish metric export of orphaned jobs

* Fixed double metric export

* Added unit tests

* increase edge package version

* Reworked if logic

---------

Co-authored-by: Marco Küttelwesch <marco.kuettelwesch@de.bosch.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:edge Edge Executor / Worker (AIP-69) / edge3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants