[Edge] Export ti.success and ti.finish metrics from edge worker#47063
Merged
jscheffl merged 9 commits intoapache:mainfrom Feb 28, 2025
Merged
Conversation
bugraoz93
reviewed
Feb 25, 2025
Contributor
bugraoz93
left a comment
There was a problem hiding this comment.
Looks good! Could you please include some tests covering new lines?
ea0eb2a to
9166d01
Compare
jscheffl
approved these changes
Feb 28, 2025
Contributor
jscheffl
left a comment
There was a problem hiding this comment.
Thanks for adding stats to the edge worker!
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
…he#47063) * edge worker exports ti.start and ti.finish metrics * Fixed wrong job fields during metric export * Extend metric exporting * Fix sql query * Fix finish metric export of orphaned jobs * Fixed double metric export * Added unit tests * increase edge package version * Reworked if logic --------- Co-authored-by: Marco Küttelwesch <marco.kuettelwesch@de.bosch.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The Edge worker currently does not move metrics which are emitted during task execution to the main Airflow instance.
This is not so easy to implement, so this PR adds the emit of ti.start and ti.finish metric. Like the main application., but with queue label extension.
Details of changes: