[AIRFLOW-3896] Add running command logging back to SSHOperator #4716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the SSH command logging back to SSHOperator
BasPH
reviewed
Feb 16, 2019
| if self.command.startswith('sudo'): | ||
| get_pty = True | ||
|
|
||
| self.logger.info("Running command: {0}".format(self.command)) |
Contributor
There was a problem hiding this comment.
self.logger is deprecated in favour of self.log.
Also, with "".format() Python constructs the string beforehand so with logging this form is preferred: self.log.info("Running command: %s", self.command) which constructs a string only when this statement is evaluated.
Change self.logger to self.log
Codecov Report
@@ Coverage Diff @@
## master #4716 +/- ##
==========================================
+ Coverage 74.65% 74.65% +<.01%
==========================================
Files 430 430
Lines 27978 27975 -3
==========================================
- Hits 20886 20885 -1
+ Misses 7092 7090 -2
Continue to review full report at Codecov.
|
Member
|
lgtm |
antonimaciej
pushed a commit
to PolideaInternal/airflow
that referenced
this pull request
Feb 26, 2019
…e#4716) * [AIRFLOW-3896] Add running command logging back to SSHOperator Add the SSH command logging back to SSHOperator * [AIRFLOW-3896] Add running command logging back to SSHOperator Change self.logger to self.log
wmorris75
pushed a commit
to modmed-external/incubator-airflow
that referenced
this pull request
Jul 29, 2019
…e#4716) * [AIRFLOW-3896] Add running command logging back to SSHOperator Add the SSH command logging back to SSHOperator * [AIRFLOW-3896] Add running command logging back to SSHOperator Change self.logger to self.log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the SSH command logging back to SSHOperator
Make sure you have checked all steps below.
Jira
Description
Until v1.8.2, the SSHExecuteOperator was able to log the running bash command.
But since v1.9.0, that logging code has been removed from SSHOperator.
Commits
Code Quality
flake8