Add root volume for airflow to keep generated config in breeze#47228
Merged
potiuk merged 1 commit intoapache:mainfrom Mar 1, 2025
Merged
Add root volume for airflow to keep generated config in breeze#47228potiuk merged 1 commit intoapache:mainfrom
potiuk merged 1 commit intoapache:mainfrom
Conversation
When configuration is generated by airflow it should be kept persistent between runs because it contains jwt_secret and fernet key that is then used to encrypt/decrypt the data (see apache#46966). This PR makes the config file persistent between runs, so that the data stored in the db and jwt_secrets can remain persistent. The `breeze down` will delete those - but they also delete the db, so syncing of the keys in config and db is "given".
potiuk
force-pushed
the
add-root-volume-for-airflow
branch
from
12f9e4b to
1f84f40
Compare
potiuk
requested review from
amoghrajesh,
gopidesupavan,
jscheffl and
mobuchowski
Member
Author
|
Better support for airflow 3 generated configuration / jwt_secrets persisted between breeze runs |
jscheffl
approved these changes
Feb 28, 2025
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Good idea! Thanks for the improvement!
eladkal
approved these changes
Mar 1, 2025
shahar1
pushed a commit
to shahar1/airflow
that referenced
this pull request
Mar 5, 2025
…e#47228) When configuration is generated by airflow it should be kept persistent between runs because it contains jwt_secret and fernet key that is then used to encrypt/decrypt the data (see apache#46966). This PR makes the config file persistent between runs, so that the data stored in the db and jwt_secrets can remain persistent. The `breeze down` will delete those - but they also delete the db, so syncing of the keys in config and db is "given".
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
…e#47228) When configuration is generated by airflow it should be kept persistent between runs because it contains jwt_secret and fernet key that is then used to encrypt/decrypt the data (see apache#46966). This PR makes the config file persistent between runs, so that the data stored in the db and jwt_secrets can remain persistent. The `breeze down` will delete those - but they also delete the db, so syncing of the keys in config and db is "given".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When configuration is generated by airflow it should be kept persistent between runs because it contains jwt_secret and fernet key that is then used to encrypt/decrypt the data (see #46966). This PR makes the config file persistent between runs, so that the data stored in the db and jwt_secrets can remain persistent.
The
breeze downwill delete those - but they also delete the db, so syncing of the keys in config and db is "given".^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.