Limit secrets passed to reusable workflows#47258
Merged
Conversation
potiuk
added
the
canary
potiuk
force-pushed
the
limit-secrets-passed
branch
2 times, most recently
from
907f41c to
eb32143
Compare
enchant3dmango
approved these changes
Mar 1, 2025
jscheffl
approved these changes
Mar 1, 2025
Good practice (pointed out by zizmor) is to explicitly only pass the needed secrets to called reusable workflows. This PR does exactly this.
jscheffl
force-pushed
the
limit-secrets-passed
branch
from
eb32143 to
a0bb2c9
Compare
Contributor
|
Merging to un-block other PRs. Leftover static check problems were fixed in #47259 |
shahar1
pushed a commit
to shahar1/airflow
that referenced
this pull request
Mar 5, 2025
Good practice (pointed out by zizmor) is to explicitly only pass the needed secrets to called reusable workflows. This PR does exactly this.
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
Good practice (pointed out by zizmor) is to explicitly only pass the needed secrets to called reusable workflows. This PR does exactly this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good practice (pointed out by zizmor) is to explicitly only pass the needed secrets to called reusable workflows. This PR does exactly this.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.