Re-order pre-commit checks so that the FastAPI spec is generated before UI client#47408
Merged
Re-order pre-commit checks so that the FastAPI spec is generated before UI client#47408
Conversation
…re UI client Otherwise you have to run pre-commit twice in order to get all changes "fully" done.
vincbeck
approved these changes
Mar 5, 2025
aritra24
approved these changes
Mar 5, 2025
Collaborator
aritra24
left a comment
aritra24
left a comment
There was a problem hiding this comment.
What's the * removed in the docs? Seems inconsequential so lgtm
bbovenzi
approved these changes
Mar 5, 2025
shahar1
approved these changes
Mar 5, 2025
sunank200
approved these changes
Mar 5, 2025
eladkal
approved these changes
Mar 5, 2025
Member
|
Nice :) |
Member
|
However, this one is not good for now - because the |
Member
|
I will do it in a moment |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Mar 6, 2025
The open-api generation (for now at least) uses the CI image to run, so it should be after "mypy" checks in order to be skippable autonatically for very simple changes (for example when README only changes - there we run only checks that do not need CI image, and the CI-image bound ones are automatically skipped). The apache#47408 moved the generate fastapi spec before the compiling (which made sense) but also removed the fastapi generation from the "CI" section of pre-commit. This PR moves both tests to the CI section - which is not a problem because if UI compilation is needed that always triggers full CI static checks.
Member
|
#47461 as follow up |
potiuk
added a commit
that referenced
this pull request
Mar 6, 2025
…47461) The open-api generation (for now at least) uses the CI image to run, so it should be after "mypy" checks in order to be skippable autonatically for very simple changes (for example when README only changes - there we run only checks that do not need CI image, and the CI-image bound ones are automatically skipped). The #47408 moved the generate fastapi spec before the compiling (which made sense) but also removed the fastapi generation from the "CI" section of pre-commit. This PR moves both tests to the CI section - which is not a problem because if UI compilation is needed that always triggers full CI static checks.
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
…pache#47461) The open-api generation (for now at least) uses the CI image to run, so it should be after "mypy" checks in order to be skippable autonatically for very simple changes (for example when README only changes - there we run only checks that do not need CI image, and the CI-image bound ones are automatically skipped). The apache#47408 moved the generate fastapi spec before the compiling (which made sense) but also removed the fastapi generation from the "CI" section of pre-commit. This PR moves both tests to the CI section - which is not a problem because if UI compilation is needed that always triggers full CI static checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise you have to run pre-commit twice in order to get all changes "fully" done.