Skip to content

Update task log styling#47466

Merged
jscheffl merged 2 commits intoapache:mainfrom
astronomer:update-log-block-styling
Mar 6, 2025
Merged

Update task log styling#47466
jscheffl merged 2 commits intoapache:mainfrom
astronomer:update-log-block-styling

Conversation

@bbovenzi
Copy link
Contributor

@bbovenzi bbovenzi commented Mar 6, 2025

  • Change the selection color for task logs. (Maybe in the future we should change it for the entire app, but I want to start small)
  • Get rid of excess padding
  • Move the Log Level to a code block so it is maintained in copy/paste actions
Screenshot 2025-03-06 at 3 13 09 PM Screenshot 2025-03-06 at 3 13 13 PM

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Mar 6, 2025
@jscheffl jscheffl merged commit 97d1645 into apache:main Mar 6, 2025
35 checks passed
@jscheffl
Copy link
Contributor

jscheffl commented Mar 6, 2025

Uuups, sorry. Wanted to approve but was clicking the wrong button :-O

@bbovenzi bbovenzi deleted the update-log-block-styling branch March 6, 2025 20:36
Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tirkarthi
Copy link
Contributor

@bbovenzi I guess this change caused some issue with log grouping where span tags causes all lines in a log group to appear in single line unlike the Text tag which makes it appear in separate lines.

This seems to render the grouped log lines as expected.

git checkout 97d1645~1 src/
Updated 2 paths from 9f0b4399d

nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Apr 4, 2025
* Update log line styling to make highlighting easier

* Change selection bg color
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants