Fix false warning about usage outside of ti for extended operators#47552
Closed
insomnes wants to merge 1 commit intoapache:mainfrom
Closed
Fix false warning about usage outside of ti for extended operators#47552insomnes wants to merge 1 commit intoapache:mainfrom
insomnes wants to merge 1 commit intoapache:mainfrom
Conversation
541b4fa to
b911454
Compare
2 tasks
Contributor
|
We already have PR for this #47523 |
Member
|
I’m going with the other PR since that one alreay has multiple approvals. |
Contributor
Author
|
Sorry, I've missed that one during search. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current
ExecutorSafeguardemits a false warning about extended operators' usage outside of the task instance.In #42849 the fix was introduced, but it's tests are flawed and depend on the testing order and values in
ExecutorSafeguardleaking between tests.An isolated call of
pytest -sv tests/models/test_baseoperatormeta.py::TestExecutorSafeguard::test_executor_when_extended_classic_operator_called_from_dagshows tests fail whilepytest -sv tests/models/test_baseoperatormeta.pyis green.Changes:
executemethods calling orders for extended operator classes by propagating sentinel via base classes keys to callersExecutorSafeguardstate between testscloses: #47511
related: #45498
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.