Add asset expression schedule popover#47645
Merged
kaxil merged 2 commits intoapache:mainfrom Mar 12, 2025
Merged
Conversation
bbovenzi
requested review from
ephraimbuddy,
jscheffl,
pierrejeambrun and
ryanahamilton
as code owners
boring-cyborg
bot
added
area:API
bbovenzi
force-pushed
the
add-schedule-popover
branch
from
8c954c5 to
a936dd3
Compare
Member
|
CI failures are unrelated |
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
For asset triggered dags, add a popover to the Schedule component to see a visualization of the asset conditions to trigger the dag. - For regularly scheduled dags, the schedule is just text with a tooltip. For Asset-triggered dags, it is a button to open a popover - Added `asset_expression` to `ui/dags` - To Do: Add event info and links to the asset details page when we add `asset_id` to `asset_expression`. Right now there is no good way to connect an expression to its actual asset. We can use this to show the queue for the next dag run, or if a dag run is selected, what events caused that dag to trigger. We could also add the Asset Event Creation trigger inside this popover. <img width="399" alt="Screenshot 2025-03-11 at 5 12 25 PM" src="https://github.com/user-attachments/assets/bb46c5eb-79a8-46fb-baf0-16f8650c32f0" /> <img width="798" alt="Screenshot 2025-03-11 at 5 12 36 PM" src="https://github.com/user-attachments/assets/ed7af4aa-4106-423b-9a40-a1aa80b3e899" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For asset triggered dags, add a popover to the Schedule component to see a visualization of the asset conditions to trigger the dag.
For regularly scheduled dags, the schedule is just text with a tooltip. For Asset-triggered dags, it is a button to open a popover
Added
asset_expressiontoui/dagsTo Do: Add event info and links to the asset details page when we add
asset_idtoasset_expression. Right now there is no good way to connect an expression to its actual asset. We can use this to show the queue for the next dag run, or if a dag run is selected, what events caused that dag to trigger. We could also add the Asset Event Creation trigger inside this popover.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.