Adding new flags to have a sanity check before bumping version in provider-documentation#47653
Adding new flags to have a sanity check before bumping version in provider-documentation#47653poorvirohidekar wants to merge 2 commits intoapache:mainfrom
Conversation
bugraoz93
left a comment
There was a problem hiding this comment.
Could you please add test cases for these newly added flags and methods? You can find the tests under dev/breeze/tests
|
Hi can i please get a review on this PR? Cc : @potiuk |
|
Will review today thanks for reminder |
|
That looks generally good - but should be rebased and I think some documentation in release management section possibly should be updated about it. Sorry for delay - but Airflow 3 and refactoring is eating all the time . |
| if _version_exists_in_changelog(provider_id, str(v)): | ||
| get_console().print( | ||
| f"[error]Version {v} already exists in CHANGELOG. Fix manually before proceeding.[/]" | ||
| ) | ||
| exit(1) |
There was a problem hiding this comment.
This will exit the process?
If detected we should show the message and let release manager fix it, once fixed it should continue from the same place. Basically, don't exit the process just redo the command for this provider after release manager fixed the issue.
Looking for something like:
Version {v} already exists in CHANGELOG. Fix manually before proceeding.
Click Y for redo this provider after fix, S to skip this provider, Q to exist the process.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
closes: #47267
This PR adds support to introduce
3 new flags --allow-already-released , --version-suffix-for-pypi, --version-suffix-for-local for the preparation of provider-documentation. This is similar to the implementation done for provider-packages to run a sanity check before bumping the version if present in
a) local tags
b) remote tags
Also add a sanity check if the version is already present in the changelog.rst for a given provider.
Testing:
this should allow the document creation
Even if an older version is given, it will pick up the version marked for release
Similarly for the command --version--suffix-for-pypi.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.