Skip to content

[AIRFLOW-3966] Correct default bigquery_conn_id in BigQueryTableSensor#4786

Closed
ryanyuan wants to merge 1 commit intoapache:masterfrom
ryanyuan:bq-table-sensor-fix-default-conn
Closed

[AIRFLOW-3966] Correct default bigquery_conn_id in BigQueryTableSensor#4786
ryanyuan wants to merge 1 commit intoapache:masterfrom
ryanyuan:bq-table-sensor-fix-default-conn

Conversation

@ryanyuan
Copy link
Contributor

@ryanyuan ryanyuan commented Feb 27, 2019

Fix default conn for BigQueryTableSensor

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow-3966 issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

Code Quality

  • Passes flake8

dataset_id,
table_id,
bigquery_conn_id='bigquery_default_conn',
bigquery_conn_id='bigquery_default',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other operators for GCP use google_cloud_default as a default connection id. Maybe we should go in this direction?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @mik-laj :-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started working in this direction, but I did not have time to finish it. If you want, you can base your work on this change.
https://github.com/PolideaInternal/airflow/pull/42/files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mik-laj @Fokko Agreed.

@mik-laj Nice initiative for your changes. Will you have time to continue working on it? If not, I would love to take the whole task. Cheers.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryanyuan I am currently dealing with other changes. Feel free and take the code / task.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mik-laj Cool! 👍

@ryanyuan ryanyuan closed this Mar 1, 2019
@ryanyuan
Copy link
Contributor Author

ryanyuan commented Mar 1, 2019

Close this PR and start working on AIRFLOW-3987 to unify all GCP connections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants