Remove pre-execute asset activeness check#47893
Merged
uranusjr merged 1 commit intoapache:mainfrom Mar 18, 2025
Merged
Conversation
We now check activeness after task execution, while emitting asset events (see 7458bd9), making this pre-execution check less needed. Removing this pre-execution check avoids a possible race condition, where a DAG is triggered too quickly after it's enabled. The scheduler needs a little time to process the enable event and register the asset as active, and a run fired too fast can be processed before that happens, causing the API to incorrectly report an asset as inactive.
uranusjr
force-pushed
the
do-not-check-activation-pre-execute
branch
from
f3e7746 to
77ab1a8
Compare
uranusjr
changed the title
Lee-W
approved these changes
Mar 18, 2025
1 task
agupta01
pushed a commit
to agupta01/airflow
that referenced
this pull request
Mar 21, 2025
We now check activeness after task execution, while emitting asset events (see 7458bd9), making this pre-execution check less needed. Removing this pre-execution check avoids a possible race condition, where a DAG is triggered too quickly after it's enabled. The scheduler needs a little time to process the enable event and register the asset as active, and a run fired too fast can be processed before that happens, causing the API to incorrectly report an asset as inactive.
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
We now check activeness after task execution, while emitting asset events (see 7458bd9), making this pre-execution check less needed. Removing this pre-execution check avoids a possible race condition, where a DAG is triggered too quickly after it's enabled. The scheduler needs a little time to process the enable event and register the asset as active, and a run fired too fast can be processed before that happens, causing the API to incorrectly report an asset as inactive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now check activeness after task execution, while emitting asset events (see #47677), making this pre-execution check less needed.
Removing this pre-execution check avoids a possible race condition, where a DAG is triggered too quickly after it's enabled. The scheduler needs a little time to process the enable event and register the asset as active, and a run fired too fast can be processed before that happens, causing the API to incorrectly report an asset as inactive.
Close #47720.