Skip to content

Comments

Honor the 'ti' while deleting XComs via execution API#47895

Merged
amoghrajesh merged 1 commit intoapache:mainfrom
astronomer:fixDeleteAPI
Mar 18, 2025
Merged

Honor the 'ti' while deleting XComs via execution API#47895
amoghrajesh merged 1 commit intoapache:mainfrom
astronomer:fixDeleteAPI

Conversation

@amoghrajesh
Copy link
Contributor

Teething problem cos of #45481.

The delete XCOM API should handle deletion better, we shouldnt be deleting for all "ti" with that key but honor the ti sent along with map_index.

Added a test that reflects this scenario well too.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:task-sdk labels Mar 18, 2025
@amoghrajesh amoghrajesh added the area:task-execution-interface-aip72 AIP-72: Task Execution Interface (TEI) aka Task SDK label Mar 18, 2025
@amoghrajesh amoghrajesh requested review from ashb and kaxil March 18, 2025 08:39
@amoghrajesh amoghrajesh changed the title Honor the ti while deleting XComs via execution API Honor the 'ti' while deleting XComs via execution API Mar 18, 2025
@amoghrajesh
Copy link
Contributor Author

The test failure is unrelated, merging.

@amoghrajesh amoghrajesh merged commit 3d8269f into apache:main Mar 18, 2025
91 of 92 checks passed
@amoghrajesh amoghrajesh deleted the fixDeleteAPI branch March 18, 2025 09:46
agupta01 pushed a commit to agupta01/airflow that referenced this pull request Mar 21, 2025
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:API Airflow's REST/HTTP API area:task-execution-interface-aip72 AIP-72: Task Execution Interface (TEI) aka Task SDK area:task-sdk

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants