Fix login redirect loop if user has multiple cookies#47913
Merged
bbovenzi merged 2 commits intoapache:mainfrom Mar 18, 2025
Merged
Fix login redirect loop if user has multiple cookies#47913bbovenzi merged 2 commits intoapache:mainfrom
bbovenzi merged 2 commits intoapache:mainfrom
Conversation
bbovenzi
requested review from
jscheffl,
pierrejeambrun and
ryanahamilton
as code owners
feluelle
approved these changes
Mar 18, 2025
ashb
reviewed
Mar 18, 2025
pierrejeambrun
approved these changes
Mar 18, 2025
agupta01
pushed a commit
to agupta01/airflow
that referenced
this pull request
Mar 21, 2025
* Fix login redirect loop if user has multiple cookies * use .trim() instead of .includes()
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
* Fix login redirect loop if user has multiple cookies * use .trim() instead of .includes()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the browser had multiple cookies, we were not fetching the auth token correctly and the user got stuck in a infinite redirect loop.
This is because cookies are often split by
;not just;^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.