Skip to content

Comments

Refactor container image to persist msodbcsql18 eula acceptance#47982

Merged
potiuk merged 3 commits intoapache:mainfrom
joeycumines-scw:persist-msodbcsql18-eula-acceptance
Mar 21, 2025
Merged

Refactor container image to persist msodbcsql18 eula acceptance#47982
potiuk merged 3 commits intoapache:mainfrom
joeycumines-scw:persist-msodbcsql18-eula-acceptance

Conversation

@joeycumines-scw
Copy link
Contributor

Hi there 👋

This PR refactors Dockerfile, Dockerfile.ci, and the script (indicated as the source of the modified code), to persist acceptance of the EULA, when installing the Microsoft ODBC driver for SQL Server, per their documentation.

The purpose of this change is to avoid unexpected failures of apt-get upgrade operations, in the event that (for example) the image published to Dockerhub is used as a base image - something I would assume is relatively common, e.g. to install dependencies of additional airflow operator implementations.

@boring-cyborg boring-cyborg bot added area:dev-tools area:production-image Production image improvements and fixes labels Mar 20, 2025
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 20, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk
Copy link
Member

potiuk commented Mar 21, 2025

nice

@potiuk potiuk merged commit 118b4cd into apache:main Mar 21, 2025
89 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 21, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

agupta01 pushed a commit to agupta01/airflow that referenced this pull request Mar 21, 2025
…he#47982)

* Update Dockerfile to persist msodbcsql18 EULA acceptance

* Update the other scripts
shubham-pyc pushed a commit to shubham-pyc/airflow that referenced this pull request Mar 22, 2025
…he#47982)

* Update Dockerfile to persist msodbcsql18 EULA acceptance

* Update the other scripts
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Apr 4, 2025
…he#47982)

* Update Dockerfile to persist msodbcsql18 EULA acceptance

* Update the other scripts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools area:production-image Production image improvements and fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants