Skip to content

[AIRFLOW-XXX] Fix CI for broken lib#4800

Merged
feng-tao merged 1 commit intoapache:masterfrom
feng-tao:tfeng_fix_ci_cryptograph
Feb 27, 2019
Merged

[AIRFLOW-XXX] Fix CI for broken lib#4800
feng-tao merged 1 commit intoapache:masterfrom
feng-tao:tfeng_fix_ci_cryptograph

Conversation

@feng-tao
Copy link
Member

It seems cryptograph 2.6 is broken in python 3 which broke our CI (issue could be found in pyca/cryptography#4789)

@feng-tao
Copy link
Member Author

PTAL @Fokko @kaxil @ashb @XD-DENG

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashb already notified everyone on the Slack channel. Would be good to stick to <2.6 until a fix has been published.

@codecov-io
Copy link

Codecov Report

Merging #4800 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4800      +/-   ##
==========================================
+ Coverage   74.37%   74.44%   +0.07%     
==========================================
  Files         450      450              
  Lines       28970    28970              
==========================================
+ Hits        21546    21567      +21     
+ Misses       7424     7403      -21
Impacted Files Coverage Δ
airflow/models/__init__.py 92.64% <0%> (+0.05%) ⬆️
airflow/www/views.py 76.27% <0%> (+0.14%) ⬆️
airflow/hooks/hive_hooks.py 75.32% <0%> (+0.26%) ⬆️
airflow/contrib/operators/cassandra_to_gcs.py 63.31% <0%> (+0.59%) ⬆️
airflow/configuration.py 92.8% <0%> (+0.71%) ⬆️
airflow/contrib/operators/mysql_to_gcs.py 52.06% <0%> (+0.82%) ⬆️
airflow/www/app.py 97.32% <0%> (+1.78%) ⬆️
.../contrib/operators/jenkins_job_trigger_operator.py 67.96% <0%> (+1.94%) ⬆️
...flow/contrib/operators/postgres_to_gcs_operator.py 95.87% <0%> (+2.06%) ⬆️
airflow/contrib/hooks/qubole_check_hook.py 71.05% <0%> (+2.63%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5db902b...74ed105. Read the comment docs.

@feng-tao
Copy link
Member Author

CI fixed. merged now.

@feng-tao feng-tao merged commit 2ade912 into apache:master Feb 27, 2019
@XD-DENG
Copy link
Member

XD-DENG commented Feb 27, 2019

Hi @feng-tao, 2.6.1 of cryptograph was released a few minutes ago.

I’m afk. Do you want to try unpinning it?

@feng-tao
Copy link
Member Author

@XD-DENG , let's keep it as it is. If anyone confirms that the issue has been fixed, we could unpin later.

andriisoldatenko pushed a commit to andriisoldatenko/airflow that referenced this pull request Jul 26, 2019
wmorris75 pushed a commit to modmed-external/incubator-airflow that referenced this pull request Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants