Remove unused num_times_parse_dags attribute from SchedulerJobRunner#48419
Merged
shahar1 merged 2 commits intoapache:mainfrom Mar 29, 2025
Merged
Remove unused num_times_parse_dags attribute from SchedulerJobRunner#48419shahar1 merged 2 commits intoapache:mainfrom
num_times_parse_dags attribute from SchedulerJobRunner#48419shahar1 merged 2 commits intoapache:mainfrom
Conversation
boring-cyborg
bot
added
the
area:Scheduler
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the unused num_times_parse_dags attribute from the SchedulerJobRunner, simplifying the scheduling loop configuration.
- Removed the num_times_parse_dags parameter from the constructor and its documentation.
- Eliminated the associated assignment and log message in the _execute method.
shahar1
added
the
airflow3.0:breaking
shahar1
force-pushed
the
remove-num-times-parse-dags
branch
2 times, most recently
from
19b8dc1 to
ac20a4d
Compare
shahar1
commented
Mar 26, 2025
shahar1
force-pushed
the
remove-num-times-parse-dags
branch
from
ac20a4d to
f73823f
Compare
ashb
reviewed
Mar 26, 2025
ashb
approved these changes
Mar 26, 2025
shahar1
removed
the
airflow3.0:breaking
Contributor
Author
|
Merging as the failing check relates to the newsfragment, which is irrelevant. |
shubham-pyc
pushed a commit
to shubham-pyc/airflow
that referenced
this pull request
Apr 2, 2025
apache#48419) * Remove unused `num_times_parse_dags` attribute from SchedulerJobRunner * Delete airflow-core/newsfragments/48419.significant.rst
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
apache#48419) * Remove unused `num_times_parse_dags` attribute from SchedulerJobRunner * Delete airflow-core/newsfragments/48419.significant.rst
simonprydden
pushed a commit
to simonprydden/airflow
that referenced
this pull request
Apr 8, 2025
apache#48419) * Remove unused `num_times_parse_dags` attribute from SchedulerJobRunner * Delete airflow-core/newsfragments/48419.significant.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.