Skip to content

Fix login form#48429

Merged
uranusjr merged 1 commit intoapache:mainfrom
astronomer:fix-login-form
Mar 27, 2025
Merged

Fix login form#48429
uranusjr merged 1 commit intoapache:mainfrom
astronomer:fix-login-form

Conversation

@uranusjr
Copy link
Member

We don't want to form to actually submit, only its keyboard behavior. The preventDefault() call makes things work.

Close #48428.

We don't want to form to actually submit, only its keyboard behavior.
The preventDefault() call makes things work.
@uranusjr uranusjr requested a review from vincbeck as a code owner March 27, 2025 04:10
@boring-cyborg boring-cyborg bot added the area:API Airflow's REST/HTTP API label Mar 27, 2025
@uranusjr uranusjr requested a review from bbovenzi March 27, 2025 04:10
@uranusjr
Copy link
Member Author

Gonna merge now to make things work. We can tweak this later if needed…

@uranusjr uranusjr merged commit 965a1cd into apache:main Mar 27, 2025
62 checks passed
@uranusjr uranusjr deleted the fix-login-form branch March 27, 2025 04:49
Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AH nice, breeze wasnt working for me :)

@vincbeck
Copy link
Contributor

Nice!

@bbovenzi
Copy link
Contributor

Good catch. Thanks!

pankajkoti pushed a commit to astronomer/airflow that referenced this pull request Mar 28, 2025
We don't want to form to actually submit, only its keyboard behavior.
The preventDefault() call makes things work.
shubham-pyc pushed a commit to shubham-pyc/airflow that referenced this pull request Apr 2, 2025
We don't want to form to actually submit, only its keyboard behavior.
The preventDefault() call makes things work.
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Apr 4, 2025
We don't want to form to actually submit, only its keyboard behavior.
The preventDefault() call makes things work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:API Airflow's REST/HTTP API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants