Skip to content

AIP-84 add 404 response for invalid routes #48545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jedcunningham merged 1 commit into from
Mar 30, 2025
Merged

AIP-84 add 404 response for invalid routes #48545

jedcunningham merged 1 commit into from
Mar 30, 2025

Conversation

@rawwar
Copy link
Contributor

@rawwar rawwar commented Mar 30, 2025

closes #48532

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Mar 30, 2025
pierrejeambrun
pierrejeambrun reviewed Mar 30, 2025
View reviewed changes
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot test this at the moment.

Is that working locally (with breeze for instance) because there’s already a catch all route for “satic_files” that could be conflicting.

@rawwar
Copy link
Contributor Author

rawwar commented Mar 30, 2025

Is that working locally (with breeze for instance) because there’s already a catch all route for “satic_files” that could be conflicting.

Yeah.

Homepage:
image

invalid non-public API route:

image

Invalid public API route:

image

Invalid UI route:

image

@rawwar rawwar requested a review from jedcunningham March 30, 2025 15:27
@jedcunningham jedcunningham merged commit d862ad9 into apache:main Mar 30, 2025
91 checks passed
pierrejeambrun
pierrejeambrun reviewed Mar 31, 2025
View reviewed changes
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks

shubham-pyc pushed a commit to shubham-pyc/airflow that referenced this pull request Apr 2, 2025
@rawwar @shubham-pyc
add 404 response for invalid routes (apache#48545)
d1713a5
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Apr 4, 2025
@rawwar @nailo2c
add 404 response for invalid routes (apache#48545)
4e5e52c
simonprydden pushed a commit to simonprydden/airflow that referenced this pull request Apr 8, 2025
@rawwar
add 404 response for invalid routes (apache#48545)
5e3e032
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierrejeambrun pierrejeambrun pierrejeambrun left review comments

@jedcunningham jedcunningham jedcunningham approved these changes

@jason810496 jason810496 jason810496 approved these changes

@jscheffl jscheffl jscheffl approved these changes

@bbovenzi bbovenzi Awaiting requested review from bbovenzi bbovenzi is a code owner

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy ephraimbuddy is a code owner

Assignees

No one assigned

Labels

area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

public api should return JSON response

5 participants

@rawwar @pierrejeambrun @jedcunningham @jason810496 @jscheffl