Introducing worker configs for task sdk#48610
Merged
amoghrajesh merged 4 commits intoapache:mainfrom Apr 1, 2025
Merged
Conversation
ashb
approved these changes
Apr 1, 2025
Member
ashb
left a comment
There was a problem hiding this comment.
Should we move where the execution api server URL is pulled form in the config in to this section too?
(If we do, lets make existing beta users' life easy and look at the current config location too)
kaxil
reviewed
Apr 1, 2025
kaxil
approved these changes
Apr 1, 2025
Contributor
Author
@ashb ill check this in a follow up. |
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
diogotrodrigues
pushed a commit
to diogotrodrigues/airflow
that referenced
this pull request
Apr 6, 2025
simonprydden
pushed a commit
to simonprydden/airflow
that referenced
this pull request
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #48590
We have hardcoded certain configs for supervisor and for worker sdk API client. Allowing these options to be configurable will allow for more flexibility.
Introducing these changes under "workers" section in config.yml that was added earlier for #48446.
Testing
Default options:
Running this:
Overriding with these environment variables.
Ran the same script from above. Works as expected.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.