Move migration drop_ab_user_id_foreign_key to FAB provider#48805
Closed
vincbeck wants to merge 1 commit intoapache:mainfrom
Closed
Move migration drop_ab_user_id_foreign_key to FAB provider#48805vincbeck wants to merge 1 commit intoapache:mainfrom
drop_ab_user_id_foreign_key to FAB provider#48805vincbeck wants to merge 1 commit intoapache:mainfrom
Conversation
boring-cyborg
bot
added
area:db-migrations
vincbeck
force-pushed
the
vincbeck/fab_migration
branch
from
19b2341 to
3cc5c34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #48457 I found out that the migration
drop_ab_user_id_foreign_keyshould not be in core but in FAB provider. We have a pre-commit checking that no migration related to FAB should be added in core but unfortunately, due to an error in the exclude list syntax, the pre-commit was not working properly.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.