Remove unnecessary ti.current_state function.#48997
Merged
Conversation
This function has exactly one use outside of tests, in a cli command, where the TI is fetched from the session directly before being passed to this function, so we can simply access the `state` attribute and (modulo a tiny window, which `current_state()` would still suffer from, albeit smaller) it will give the same result This is a small drive by tidy up.
kaxil
approved these changes
Apr 9, 2025
pierrejeambrun
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function has exactly one use outside of tests, in a cli command, where
the TI is fetched from the session directly before being passed to this
function, so we can simply access the
stateattribute and (modulo a tinywindow, which
current_state()would still suffer from, albeit smaller) itwill give the same result
This is a small drive by tidy up.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.