Load TI related objects when purging TIs without heartbeat#49246
Merged
vatsrahul1001 merged 1 commit intoapache:mainfrom Apr 15, 2025
Merged
Load TI related objects when purging TIs without heartbeat#49246vatsrahul1001 merged 1 commit intoapache:mainfrom
vatsrahul1001 merged 1 commit intoapache:mainfrom
Conversation
boring-cyborg
bot
added
the
area:Scheduler
ephraimbuddy
force-pushed
the
load-ti-relationships
branch
from
e4d3be1 to
4e13812
Compare
This query joins to DagModel but doesn't load the TI related dag_model or any other related objects used in the following TaskCallbackRequest Arguments resulting in detached instance error when requesting callback. This PR fixes it by using selectinload for fast loading of the related objects used in the TaskCallbackRequest
ephraimbuddy
force-pushed
the
load-ti-relationships
branch
from
4e13812 to
05c5673
Compare
vatsrahul1001
approved these changes
Apr 15, 2025
phanikumv
approved these changes
Apr 15, 2025
ashb
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This query joins to DagModel but doesn't load the TI related dag_model or any other
related objects used in the following TaskCallbackRequest Arguments, resulting in
detached instance error when requesting callback.
This PR fixes it by using selectinload for fast loading of the related
objects used in the TaskCallbackRequest