Skip to content

[AIRFLOW-4148]form_choices in DagRunModelView may be wrong#4969

Closed
sumous wants to merge 1 commit intoapache:v1-10-stablefrom
sumous:v1-10-stable
Closed

[AIRFLOW-4148]form_choices in DagRunModelView may be wrong#4969
sumous wants to merge 1 commit intoapache:v1-10-stablefrom
sumous:v1-10-stable

Conversation

@sumous
Copy link
Contributor

@sumous sumous commented Mar 25, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-4148
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@sumous sumous changed the title form_choices in DagRunModelView may be wrong [AIRFLOW-4148]form_choices in DagRunModelView may be wrong Mar 25, 2019
@XD-DENG
Copy link
Member

XD-DENG commented Mar 27, 2019

Hi @sumous , I see nothing wrong from the current code.

May you attach a screenshot with the issue/error/bug you encountered? So that it will be easier for us to process your PR.

@sumous
Copy link
Contributor Author

sumous commented Mar 28, 2019

Hi,
I test it in mac air. python2.7 and python3.6 both got this error.
Airflow v1.10.1 depends on Flask-Admin v1.4.1, and Airflow v1.10.2 depends on Flask-Admin v1.5.2. The bug appeared because of Flask-Admin PR

screenshot like this:
image

@ashb
Copy link
Member

ashb commented Mar 29, 2019

Try on Airflow 1.10.2?

@sumous
Copy link
Contributor Author

sumous commented Mar 29, 2019

Yes!
It also happen on kali linux.
image

@sumous
Copy link
Contributor Author

sumous commented Apr 10, 2019

@ashb Did you reproduce this bug?

@stale
Copy link

stale bot commented May 25, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label May 25, 2019
@sumous sumous closed this May 27, 2019
ashb pushed a commit to ashb/airflow that referenced this pull request Jun 19, 2019
The update from Flask-Admin to 1.5.2 broke editing the state by clicking
on the column. This makes it work again (although the edited column is
no-longer styled once edited). This is good enough a fix for the
deprecated UI

(Authorship and commit taken from apache#4969)
ashb added a commit that referenced this pull request Jun 19, 2019
The update from Flask-Admin to 1.5.2 broke editing the state by clicking
on the column. This makes it work again (although the edited column is
no-longer styled once edited). This is good enough a fix for the
deprecated UI

(Authorship and commit taken from #4969)
dharamsk pushed a commit to postmates/airflow that referenced this pull request Aug 8, 2019
…#5436)

The update from Flask-Admin to 1.5.2 broke editing the state by clicking
on the column. This makes it work again (although the edited column is
no-longer styled once edited). This is good enough a fix for the
deprecated UI

(Authorship and commit taken from apache#4969)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants