[AIRFLOW-4148]form_choices in DagRunModelView may be wrong#4969
Closed
sumous wants to merge 1 commit intoapache:v1-10-stablefrom
sumous:v1-10-stable
Closed
[AIRFLOW-4148]form_choices in DagRunModelView may be wrong#4969sumous wants to merge 1 commit intoapache:v1-10-stablefrom sumous:v1-10-stable
sumous wants to merge 1 commit intoapache:v1-10-stablefrom
sumous:v1-10-stable
Conversation
Member
|
Hi @sumous , I see nothing wrong from the current code. May you attach a screenshot with the issue/error/bug you encountered? So that it will be easier for us to process your PR. |
Contributor
Author
|
Hi, |
Member
|
Try on Airflow 1.10.2? |
Contributor
Author
Contributor
Author
|
@ashb Did you reproduce this bug? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
ashb
pushed a commit
to ashb/airflow
that referenced
this pull request
Jun 19, 2019
The update from Flask-Admin to 1.5.2 broke editing the state by clicking on the column. This makes it work again (although the edited column is no-longer styled once edited). This is good enough a fix for the deprecated UI (Authorship and commit taken from apache#4969)
6 tasks
ashb
added a commit
that referenced
this pull request
Jun 19, 2019
The update from Flask-Admin to 1.5.2 broke editing the state by clicking on the column. This makes it work again (although the edited column is no-longer styled once edited). This is good enough a fix for the deprecated UI (Authorship and commit taken from #4969)
dharamsk
pushed a commit
to postmates/airflow
that referenced
this pull request
Aug 8, 2019
…#5436) The update from Flask-Admin to 1.5.2 broke editing the state by clicking on the column. This makes it work again (although the edited column is no-longer styled once edited). This is good enough a fix for the deprecated UI (Authorship and commit taken from apache#4969)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Make sure you have checked all steps below.
Jira
Description
Tests
Commits
Documentation
Code Quality
flake8