Skip to content

Fix PluginImportErrors error assertion#49719

Merged
bbovenzi merged 2 commits intoapache:mainfrom
guan404ming:fix-import-plugin
Apr 24, 2025
Merged

Fix PluginImportErrors error assertion#49719
bbovenzi merged 2 commits intoapache:mainfrom
guan404ming:fix-import-plugin

Conversation

@guan404ming
Copy link
Member

@guan404ming guan404ming commented Apr 24, 2025

Related Issue

#49643
cc: @pierrejeambrun

Why

if ((error as ExpandedApiError).status === 403)
  • if error is undefined or null, it would crash

How

  • add a assertion for error

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Apr 24, 2025
@guan404ming guan404ming changed the title fix: PlugiuImportErrors assertion fix: PlugiuImportErrors error assertion Apr 24, 2025
@tirkarthi tirkarthi changed the title fix: PlugiuImportErrors error assertion fix: PluginImportErrors error assertion Apr 24, 2025
@guan404ming
Copy link
Member Author

Thanks for reviewing~

@bbovenzi bbovenzi merged commit 74cafa2 into apache:main Apr 24, 2025
42 checks passed
@pierrejeambrun
Copy link
Member

Thanks, don't know how the eslint didn't find that error 🤔. (I tested on the viewer user and forgot to test back on the admin one, bot are working well now, thanks)

@guan404ming guan404ming deleted the fix-import-plugin branch April 24, 2025 15:25
@pierrejeambrun pierrejeambrun added this to the Airflow 3.1+ milestone Apr 25, 2025
prabhusneha pushed a commit to astronomer/airflow that referenced this pull request Apr 25, 2025
jroachgolf84 pushed a commit to jroachgolf84/airflow that referenced this pull request Apr 30, 2025
@guan404ming guan404ming changed the title fix: PluginImportErrors error assertion Fix PluginImportErrors error assertion Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants