Skip to content

Comments

Ensure K8s tests are completed before finalization#49827

Merged
jscheffl merged 2 commits intoapache:mainfrom
jscheffl:bugfix/ensure-k8s-is-completed-before-finalization
Apr 26, 2025
Merged

Ensure K8s tests are completed before finalization#49827
jscheffl merged 2 commits intoapache:mainfrom
jscheffl:bugfix/ensure-k8s-is-completed-before-finalization

Conversation

@jscheffl
Copy link
Contributor

@jscheffl jscheffl enabled auto-merge (squash) April 26, 2025 15:24
@jscheffl jscheffl disabled auto-merge April 26, 2025 15:24
@jscheffl jscheffl enabled auto-merge (squash) April 26, 2025 15:24
@jscheffl jscheffl changed the title EEnsure K8s tests are completed before finalization Ensure K8s tests are completed before finalization Apr 26, 2025
@jscheffl jscheffl added the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label Apr 26, 2025
@jscheffl jscheffl disabled auto-merge April 26, 2025 15:33
@jscheffl
Copy link
Contributor Author

Ups, I assume there is mow not depending on "finalize" :-(

@potiuk
Copy link
Member

potiuk commented Apr 26, 2025

Indeed. Actually that was quite deliberate... because k8s tests were generally slow and brittle, but they are much more stable now after separatlng them to individual jobs, so we should be able to bring back this dependnecy.

@potiuk potiuk added this to the Airflow 3.0.1 milestone Apr 26, 2025
potiuk
potiuk previously approved these changes Apr 26, 2025
@jscheffl jscheffl dismissed potiuk’s stale review April 26, 2025 15:35

Sorry, need re-review :-D

@jscheffl
Copy link
Contributor Author

@potiuk mhm, now I checked and also task sdk and airflowctl were independent of finalize. Either we need a general finalizer or... as now here in the PR all tests which were previously before Slack notification are dependency to finalize.... and Slack only depends on finalization... don't know if this is "good"?
...or we need a "final final check" which is required to auto-merge

@gopidesupavan
Copy link
Member

@potiuk mhm, now I checked and also task sdk and airflowctl were independent of finalize. Either we need a general finalizer or... as now here in the PR all tests which were previously before Slack notification are dependency to finalize.... and Slack only depends on finalization... don't know if this is "good"? ...or we need a "final final check" which is required to auto-merge

Its fine i guess under one finalisation.

@jscheffl jscheffl requested a review from potiuk April 26, 2025 16:17
@jscheffl jscheffl force-pushed the bugfix/ensure-k8s-is-completed-before-finalization branch from d72bc05 to 393b8e3 Compare April 26, 2025 17:11
@jscheffl jscheffl enabled auto-merge (squash) April 26, 2025 17:12
@jscheffl jscheffl merged commit fcacd12 into apache:main Apr 26, 2025
97 of 98 checks passed
@github-actions
Copy link

Backport failed to create: v3-0-test. View the failure log Run details

Status Branch Result
v3-0-test Commit Link

You can attempt to backport this manually by running:

cherry_picker fcacd12 v3-0-test

This should apply the commit to the v3-0-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

jscheffl added a commit to jscheffl/airflow that referenced this pull request Apr 26, 2025
…e#49827)

* Ensure K8s tests are completed before finalization

* Add more tests as dependency
(cherry picked from commit fcacd12)

Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
jscheffl added a commit that referenced this pull request Apr 26, 2025
… (#49832)

* Ensure K8s tests are completed before finalization

* Add more tests as dependency
(cherry picked from commit fcacd12)
jroachgolf84 pushed a commit to jroachgolf84/airflow that referenced this pull request Apr 30, 2025
* Ensure K8s tests are completed before finalization

* Add more tests as dependency
@jscheffl jscheffl deleted the bugfix/ensure-k8s-is-completed-before-finalization branch October 5, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants