Skip to content

Comments

Manually run workflows are now also canary runs#49946

Merged
potiuk merged 1 commit intoapache:mainfrom
potiuk:switch-manually-dispatched-runs-to-canary-runs
Apr 29, 2025
Merged

Manually run workflows are now also canary runs#49946
potiuk merged 1 commit intoapache:mainfrom
potiuk:switch-manually-dispatched-runs-to-canary-runs

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Apr 29, 2025

We had the issue that when we run manually tests using worfklow-dispatch, tests were not running because the run was not considered as canary run.

This PR fixes it.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@potiuk
Copy link
Member Author

potiuk commented Apr 29, 2025

example run here:

image

@potiuk potiuk added this to the Airflow 3.0.1 milestone Apr 29, 2025
@potiuk potiuk added the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label Apr 29, 2025
@potiuk potiuk requested a review from pierrejeambrun April 29, 2025 10:36
We had the issue that when we run manually tests using
worfklow-dispatch, tests were not running because the run was not
considered as canary run.

This PR fixes it.
@potiuk potiuk force-pushed the switch-manually-dispatched-runs-to-canary-runs branch from 34ec31e to a9d4f7b Compare April 29, 2025 11:17
@potiuk potiuk merged commit 0315a46 into apache:main Apr 29, 2025
97 checks passed
@potiuk potiuk deleted the switch-manually-dispatched-runs-to-canary-runs branch April 29, 2025 12:31
github-actions bot pushed a commit that referenced this pull request Apr 29, 2025
We had the issue that when we run manually tests using
worfklow-dispatch, tests were not running because the run was not
considered as canary run.

This PR fixes it.
(cherry picked from commit 0315a46)

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
@github-actions
Copy link

Backport successfully created: v3-0-test

Status Branch Result
v3-0-test PR Link

github-actions bot pushed a commit to guan404ming/airflow that referenced this pull request Apr 29, 2025
…9946)

We had the issue that when we run manually tests using
worfklow-dispatch, tests were not running because the run was not
considered as canary run.

This PR fixes it.
(cherry picked from commit 0315a46)

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
mvfc pushed a commit to mvfc/airflow that referenced this pull request Apr 29, 2025
We had the issue that when we run manually tests using
worfklow-dispatch, tests were not running because the run was not
considered as canary run.

This PR fixes it.
potiuk added a commit that referenced this pull request Apr 29, 2025
…49953)

We had the issue that when we run manually tests using
worfklow-dispatch, tests were not running because the run was not
considered as canary run.

This PR fixes it.
(cherry picked from commit 0315a46)

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
mvfc pushed a commit to mvfc/airflow that referenced this pull request Apr 29, 2025
We had the issue that when we run manually tests using
worfklow-dispatch, tests were not running because the run was not
considered as canary run.

This PR fixes it.
jroachgolf84 pushed a commit to jroachgolf84/airflow that referenced this pull request Apr 30, 2025
We had the issue that when we run manually tests using
worfklow-dispatch, tests were not running because the run was not
considered as canary run.

This PR fixes it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants