[v3-0-test] Remove unnecessary noise from CI breeze's output (#49952)#49958
Merged
[v3-0-test] Remove unnecessary noise from CI breeze's output (#49952)#49958
Conversation
CI tests with breeze are running with `--verbose` options in order to get more diagnostics when things fail. However there were a few commmands always executed at the end of every command in breeze which did not add any value for diagnostics and only generated noise: * id retrievals for users and groups * fixing ownership * checking for rootless docker Those commmands are now silecenced with `quiet=True` of run_command, and the command nicely handles the case where we also capture output of such command. (cherry picked from commit 36766d1) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk
requested review from
ashb,
gopidesupavan,
jedcunningham and
potiuk
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI tests with breeze are running with
--verboseoptions in order toget more diagnostics when things fail. However there were a few
commmands always executed at the end of every command in breeze which
did not add any value for diagnostics and only generated noise:
Those commmands are now silecenced with
quiet=Trueof run_command,and the command nicely handles the case where we also capture output
of such command.
(cherry picked from commit 36766d1)
Co-authored-by: Jarek Potiuk jarek@potiuk.com