Skip to content

Fix failing dashboard queing tests#50046

Merged
potiuk merged 1 commit intoapache:mainfrom
potiuk:fix-dashboard-failing-tests
Apr 30, 2025
Merged

Fix failing dashboard queing tests#50046
potiuk merged 1 commit intoapache:mainfrom
potiuk:fix-dashboard-failing-tests

Conversation

@potiuk
Copy link
Copy Markdown
Member

@potiuk potiuk commented Apr 30, 2025

Main started failing after #49961

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added the area:API Airflow's REST/HTTP API label Apr 30, 2025
@tirkarthi
Copy link
Copy Markdown
Contributor

tirkarthi commented Apr 30, 2025

cc: @pierrejeambrun

@potiuk potiuk requested a review from pierrejeambrun April 30, 2025 18:46
@potiuk potiuk added this to the Airflow 3.0.1 milestone Apr 30, 2025
@potiuk potiuk mentioned this pull request Apr 30, 2025
Merged
guan404ming
guan404ming approved these changes Apr 30, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@guan404ming guan404ming left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test was written by me. I think the failing cause is the addition of

airflow/airflow-core/tests/unit/api_fastapi/core_api/routes/ui/test_dashboard.py

Lines 93 to 98 in 58c736a

dag_maker.create_dagrun(
run_id="run_4",
state=DagRunState.QUEUED,
run_type=DagRunType.SCHEDULED,
logical_date=date + timedelta(days=3),
)

Thus, this PR could solve the fail in ci.

@potiuk potiuk enabled auto-merge (squash) April 30, 2025 19:08
@potiuk potiuk requested review from gopidesupavan and guan404ming and removed request for guan404ming April 30, 2025 19:32
@potiuk potiuk merged commit 5f4bcc1 into apache:main Apr 30, 2025
100 checks passed
@potiuk potiuk deleted the fix-dashboard-failing-tests branch April 30, 2025 19:43
github-actions bot pushed a commit that referenced this pull request Apr 30, 2025
@potiuk
[v3-0-test] Fix failing dashboard queing tests (#50046)
a0bdb34 
Main started failing after #49961
(cherry picked from commit 5f4bcc1)

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 30, 2025

Backport successfully created: v3-0-test

Status Branch Result
✅ v3-0-test PR Link

potiuk added a commit that referenced this pull request Apr 30, 2025
@github-actions @potiuk
[v3-0-test] Fix failing dashboard queing tests (#50046) (#50052)
9ff257f 
Main started failing after #49961
(cherry picked from commit 5f4bcc1)

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
@pierrejeambrun
Copy link
Copy Markdown
Member

pierrejeambrun commented Apr 30, 2025

Thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gopidesupavan gopidesupavan gopidesupavan approved these changes

@guan404ming guan404ming guan404ming approved these changes

@pierrejeambrun pierrejeambrun Awaiting requested review from pierrejeambrun

Assignees

No one assigned

Labels

area:API Airflow's REST/HTTP API

Projects

None yet

Milestone

Airflow 3.0.1

Development

Successfully merging this pull request may close these issues.

5 participants

@potiuk @tirkarthi @pierrejeambrun @gopidesupavan @guan404ming