Skip to content

Conversation

@zhongjiajie
Copy link
Member

Make sure you have checked all steps below.

Jira

Description

Code Quality

  • Passes flake8

@Fokko
Copy link
Contributor

Fokko commented Apr 12, 2019

Can you rebase onto master?

@zhongjiajie zhongjiajie force-pushed the remove_all_future_import branch 2 times, most recently from 21ccba5 to 703e633 Compare April 12, 2019 11:44
@zhongjiajie
Copy link
Member Author

CI failed because our CI process have py2 envirement, I submit a PR #5090 to remove them. @Fokko

@Fokko
Copy link
Contributor

Fokko commented Apr 14, 2019

It looks like the K8s tests still use Python 2.7:

+ airflow initdb
Traceback (most recent call last):
  File "/usr/local/bin/airflow", line 21, in <module>
    from airflow import configuration
  File "/usr/local/lib/python2.7/dist-packages/airflow/__init__.py", line 36, in <module>
    from airflow import settings, configuration as conf
  File "/usr/local/lib/python2.7/dist-packages/airflow/settings.py", line 32, in <module>
    from airflow.utils.sqlalchemy import setup_event_handlers
  File "/usr/local/lib/python2.7/dist-packages/airflow/utils/sqlalchemy.py", line 22, in <module>
    import json
  File "/usr/local/lib/python2.7/dist-packages/airflow/utils/json.py", line 27, in <module>
    class AirflowJsonEncoder(json.JSONEncoder):
AttributeError: 'module' object has no attribute 'JSONEncoder'

@zhongjiajie zhongjiajie force-pushed the remove_all_future_import branch from 703e633 to dddce56 Compare April 21, 2019 04:00
@codecov-io
Copy link

codecov-io commented Apr 21, 2019

Codecov Report

Merging #5020 into master will increase coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5020      +/-   ##
=========================================
+ Coverage   78.08%   78.3%   +0.22%     
=========================================
  Files         465     465              
  Lines       29803   29706      -97     
=========================================
- Hits        23271   23262       -9     
+ Misses       6532    6444      -88
Impacted Files Coverage Δ
airflow/configuration.py 90.62% <ø> (-0.13%) ⬇️
airflow/utils/log/logging_mixin.py 96.1% <ø> (-0.2%) ⬇️
airflow/bin/cli.py 66.63% <ø> (-0.04%) ⬇️
...example_dags/example_kubernetes_executor_config.py 0% <ø> (ø) ⬆️
airflow/utils/state.py 96.42% <ø> (-0.13%) ⬇️
airflow/contrib/operators/cassandra_to_gcs.py 63.09% <ø> (-0.22%) ⬇️
airflow/dag/base_dag.py 60% <ø> (-6.67%) ⬇️
airflow/utils/helpers.py 82.39% <ø> (-0.49%) ⬇️
airflow/settings.py 83.87% <ø> (-0.51%) ⬇️
airflow/hooks/hive_hooks.py 75.06% <ø> (+1.78%) ⬆️
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ac501f...dddce56. Read the comment docs.

@zhongjiajie
Copy link
Member Author

CI green, PTAL @Fokko @potiuk @XD-DENG thanks.

@potiuk potiuk merged commit d2a2e2c into apache:master Apr 22, 2019
@zhongjiajie zhongjiajie deleted the remove_all_future_import branch April 22, 2019 10:25
@zhongjiajie
Copy link
Member Author

Thanks @potiuk

zhongjiajie added a commit to zhongjiajie/airflow that referenced this pull request May 5, 2019
Remove _future_ should done in
apache#5020, but in
the same time our code base refactor models and
move some code out of _init.py. This PR to remove
__future__ in models.
XD-DENG pushed a commit that referenced this pull request May 5, 2019
Remove _future_ should done in
#5020, but in
the same time our code base refactor models and
move some code out of _init.py. This PR to remove
__future__ in models.
JCoder01 pushed a commit to JCoder01/airflow that referenced this pull request May 14, 2019
Remove _future_ should done in
apache#5020, but in
the same time our code base refactor models and
move some code out of _init.py. This PR to remove
__future__ in models.
andriisoldatenko pushed a commit to andriisoldatenko/airflow that referenced this pull request Jul 26, 2019
andriisoldatenko pushed a commit to andriisoldatenko/airflow that referenced this pull request Jul 26, 2019
Remove _future_ should done in
apache#5020, but in
the same time our code base refactor models and
move some code out of _init.py. This PR to remove
__future__ in models.
wmorris75 pushed a commit to modmed-external/incubator-airflow that referenced this pull request Jul 29, 2019
wmorris75 pushed a commit to modmed-external/incubator-airflow that referenced this pull request Jul 29, 2019
Remove _future_ should done in
apache#5020, but in
the same time our code base refactor models and
move some code out of _init.py. This PR to remove
__future__ in models.
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 15, 2021
Remove _future_ should done in
apache/airflow#5020, but in
the same time our code base refactor models and
move some code out of _init.py. This PR to remove
__future__ in models.

GitOrigin-RevId: 97ad71c99373759cc022733b2732c3bd43af983d
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 16, 2021
Remove _future_ should done in
apache/airflow#5020, but in
the same time our code base refactor models and
move some code out of _init.py. This PR to remove
__future__ in models.

GitOrigin-RevId: 97ad71c99373759cc022733b2732c3bd43af983d
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 23, 2021
Remove _future_ should done in
apache/airflow#5020, but in
the same time our code base refactor models and
move some code out of _init.py. This PR to remove
__future__ in models.

GitOrigin-RevId: 97ad71c99373759cc022733b2732c3bd43af983d
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Nov 25, 2021
Remove _future_ should done in
apache/airflow#5020, but in
the same time our code base refactor models and
move some code out of _init.py. This PR to remove
__future__ in models.

GitOrigin-RevId: 97ad71c99373759cc022733b2732c3bd43af983d
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Mar 1, 2022
Remove _future_ should done in
apache/airflow#5020, but in
the same time our code base refactor models and
move some code out of _init.py. This PR to remove
__future__ in models.

GitOrigin-RevId: 97ad71c99373759cc022733b2732c3bd43af983d
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jun 3, 2022
Remove _future_ should done in
apache/airflow#5020, but in
the same time our code base refactor models and
move some code out of _init.py. This PR to remove
__future__ in models.

GitOrigin-RevId: 97ad71c99373759cc022733b2732c3bd43af983d
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jun 6, 2022
Remove _future_ should done in
apache/airflow#5020, but in
the same time our code base refactor models and
move some code out of _init.py. This PR to remove
__future__ in models.

GitOrigin-RevId: 97ad71c99373759cc022733b2732c3bd43af983d
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jul 8, 2022
Remove _future_ should done in
apache/airflow#5020, but in
the same time our code base refactor models and
move some code out of _init.py. This PR to remove
__future__ in models.

GitOrigin-RevId: 97ad71c99373759cc022733b2732c3bd43af983d
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Aug 26, 2022
Remove _future_ should done in
apache/airflow#5020, but in
the same time our code base refactor models and
move some code out of _init.py. This PR to remove
__future__ in models.

GitOrigin-RevId: 97ad71c99373759cc022733b2732c3bd43af983d
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 3, 2022
Remove _future_ should done in
apache/airflow#5020, but in
the same time our code base refactor models and
move some code out of _init.py. This PR to remove
__future__ in models.

GitOrigin-RevId: 97ad71c99373759cc022733b2732c3bd43af983d
aglipska pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 6, 2022
Remove _future_ should done in
apache/airflow#5020, but in
the same time our code base refactor models and
move some code out of _init.py. This PR to remove
__future__ in models.

GitOrigin-RevId: 97ad71c99373759cc022733b2732c3bd43af983d
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Dec 7, 2022
Remove _future_ should done in
apache/airflow#5020, but in
the same time our code base refactor models and
move some code out of _init.py. This PR to remove
__future__ in models.

GitOrigin-RevId: 97ad71c99373759cc022733b2732c3bd43af983d
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jan 27, 2023
Remove _future_ should done in
apache/airflow#5020, but in
the same time our code base refactor models and
move some code out of _init.py. This PR to remove
__future__ in models.

GitOrigin-RevId: 97ad71c99373759cc022733b2732c3bd43af983d
ahidalgob pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Apr 24, 2023
Remove _future_ should done in
apache/airflow#5020, but in
the same time our code base refactor models and
move some code out of _init.py. This PR to remove
__future__ in models.

GitOrigin-RevId: 97ad71c99373759cc022733b2732c3bd43af983d
kosteev pushed a commit to kosteev/composer-airflow-test-copybara that referenced this pull request Sep 11, 2024
Remove _future_ should done in
apache/airflow#5020, but in
the same time our code base refactor models and
move some code out of _init.py. This PR to remove
__future__ in models.

GitOrigin-RevId: 97ad71c99373759cc022733b2732c3bd43af983d
kosteev pushed a commit to kosteev/composer-airflow-test-copybara that referenced this pull request Sep 12, 2024
Remove _future_ should done in
apache/airflow#5020, but in
the same time our code base refactor models and
move some code out of _init.py. This PR to remove
__future__ in models.

GitOrigin-RevId: 97ad71c99373759cc022733b2732c3bd43af983d
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 16, 2024
Remove _future_ should done in
apache/airflow#5020, but in
the same time our code base refactor models and
move some code out of _init.py. This PR to remove
__future__ in models.

GitOrigin-RevId: 97ad71c99373759cc022733b2732c3bd43af983d
kosteev pushed a commit to kosteev/composer-airflow-test-copybara that referenced this pull request Sep 17, 2024
Remove _future_ should done in
apache/airflow#5020, but in
the same time our code base refactor models and
move some code out of _init.py. This PR to remove
__future__ in models.

GitOrigin-RevId: 97ad71c99373759cc022733b2732c3bd43af983d
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Nov 6, 2024
Remove _future_ should done in
apache/airflow#5020, but in
the same time our code base refactor models and
move some code out of _init.py. This PR to remove
__future__ in models.

GitOrigin-RevId: 97ad71c99373759cc022733b2732c3bd43af983d
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Apr 30, 2025
Remove _future_ should done in
apache/airflow#5020, but in
the same time our code base refactor models and
move some code out of _init.py. This PR to remove
__future__ in models.

GitOrigin-RevId: 97ad71c99373759cc022733b2732c3bd43af983d
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request May 20, 2025
Remove _future_ should done in
apache/airflow#5020, but in
the same time our code base refactor models and
move some code out of _init.py. This PR to remove
__future__ in models.

GitOrigin-RevId: 97ad71c99373759cc022733b2732c3bd43af983d
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 15, 2025
Remove _future_ should done in
apache/airflow#5020, but in
the same time our code base refactor models and
move some code out of _init.py. This PR to remove
__future__ in models.

GitOrigin-RevId: 97ad71c99373759cc022733b2732c3bd43af983d
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 14, 2025
Remove _future_ should done in
apache/airflow#5020, but in
the same time our code base refactor models and
move some code out of _init.py. This PR to remove
__future__ in models.

GitOrigin-RevId: 97ad71c99373759cc022733b2732c3bd43af983d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants