Skip to content

Conversation

@BasPH
Copy link
Contributor

@BasPH BasPH commented Apr 1, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-4206
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Python 3 classes implicitly inherit from object so there's no need anymore to define class MyClass(object): ... (in Python 3 this is equivalent to class MyClass: ...). In this PR I removed all such cases.

Note that https://jira.apache.org/jira/browse/AIRFLOW-4197 must be merged before this PR, since (obviously) the Python 2 jobs are failing.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@Fokko
Copy link
Contributor

Fokko commented Apr 12, 2019

Can you rebase onto master?

@codecov-io
Copy link

Codecov Report

Merging #5021 into master will decrease coverage by <.01%.
The diff coverage is 92.1%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5021      +/-   ##
==========================================
- Coverage   78.68%   78.67%   -0.01%     
==========================================
  Files         470      470              
  Lines       30018    30013       -5     
==========================================
- Hits        23619    23614       -5     
  Misses       6399     6399
Impacted Files Coverage Δ
...ow/contrib/auth/backends/github_enterprise_auth.py 0% <0%> (ø) ⬆️
airflow/contrib/auth/backends/google_auth.py 0% <0%> (ø) ⬆️
...rflow/contrib/utils/mlengine_prediction_summary.py 0% <0%> (ø) ⬆️
airflow/www/utils.py 82.7% <100%> (ø) ⬆️
airflow/bin/cli.py 66.83% <100%> (ø) ⬆️
airflow/utils/state.py 96.29% <100%> (-0.14%) ⬇️
airflow/dag/base_dag.py 66.66% <100%> (ø) ⬆️
airflow/contrib/hooks/bigquery_hook.py 61.08% <100%> (ø) ⬆️
airflow/executors/celery_executor.py 76.92% <100%> (ø) ⬆️
airflow/executors/local_executor.py 82.35% <100%> (ø) ⬆️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3185eab...51b5128. Read the comment docs.

@BasPH
Copy link
Contributor Author

BasPH commented May 6, 2019

@Fokko rebased

@potiuk potiuk merged commit e76020c into apache:master May 6, 2019
JCoder01 pushed a commit to JCoder01/airflow that referenced this pull request May 14, 2019
andriisoldatenko pushed a commit to andriisoldatenko/airflow that referenced this pull request Jul 26, 2019
wmorris75 pushed a commit to modmed-external/incubator-airflow that referenced this pull request Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants