Skip to content

AIRFLOW-4218 Support to Provide http args to K8executor while calling…#5034

Closed
andy-g14 wants to merge 1 commit intoapache:masterfrom
andy-g14:AIRFLOW-4218
Closed

AIRFLOW-4218 Support to Provide http args to K8executor while calling…#5034
andy-g14 wants to merge 1 commit intoapache:masterfrom
andy-g14:AIRFLOW-4218

Conversation

@andy-g14
Copy link
Contributor

@andy-g14 andy-g14 commented Apr 4, 2019

… k8 python client lib apis

Make sure you have checked all steps below.

Jira

Description

Kubernetes Python client corev1 apis supports passing arguments like timeouts, async, etc. - https://github.com/kubernetes-client/python/blob/master/kubernetes/client/apis/core_v1_api.py
I would want to pass these arguments when using K8Executor mode by specifying args in kubernetes section of airflow.cfg as single line json dict string.

PS. args only used in K8executor and not in K8PodOperator.

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@andy-g14 andy-g14 force-pushed the AIRFLOW-4218 branch 4 times, most recently from d445a12 to e704540 Compare April 4, 2019 13:37
@ashb ashb added the k8s label Apr 5, 2019
@feng-tao
Copy link
Member

feng-tao commented Apr 6, 2019

cc @dimberman

@andy-g14 andy-g14 closed this Apr 8, 2019
@andy-g14 andy-g14 deleted the AIRFLOW-4218 branch April 8, 2019 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants