[AIRFLOW-4204][WIP] Update super() calls#5042
Closed
milton0825 wants to merge 2 commits intoapache:masterfrom
Closed
[AIRFLOW-4204][WIP] Update super() calls#5042milton0825 wants to merge 2 commits intoapache:masterfrom
milton0825 wants to merge 2 commits intoapache:masterfrom
Conversation
312a185 to
c51679f
Compare
BasPH
reviewed
Apr 5, 2019
| # if this is a valid command key... | ||
| if (section, key) in self.as_command_stdout: | ||
| if super(AirflowConfigParser, self) \ | ||
| if super() \ |
Contributor
There was a problem hiding this comment.
This formatting looks a bit odd now, these 2 lines easily fit on a single line. Could you fix these formatting issues?
Contributor
Author
There was a problem hiding this comment.
Will start fixing it once #5022 is merged.
Contributor
|
Contributor
|
Can you rebase onto master? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Jira
Description
Replace
super(_class, self)bysuper()find . -type f -name "*.py" -print0 | xargs -0 sed -i .pyc 's/super(.*, self)/super()/g'Tests
Not changing any functionality so no test required.
Commits
Documentation
Code Quality
flake8