Revert "Bypass go module proxies while installing libraries for preco…#51261
Merged
potiuk merged 1 commit intoapache:mainfrom May 31, 2025
Merged
Conversation
potiuk
force-pushed
the
replace-golang-env-with-instructions
branch
from
e04dfbc to
0ec26c1
Compare
…mmit (apache#51232)" This reverts commit a8054bf.
potiuk
force-pushed
the
replace-golang-env-with-instructions
branch
from
0ec26c1 to
3a46edd
Compare
Member
Author
|
How about this one @amoghrajesh @eladkal ? That has the advantage that only people who have problem, will get instructions on how to set their proxy? |
Member
Author
|
BTW. I don't think there is an easy way to make it works "always" automatically - > the default setting works for most people and it's good for caching and I guess also the rate limits for GitHub recently might cause problems for people if direct is used too often. |
hussein-awala
approved these changes
May 31, 2025
Member
Author
|
I merge it now to avoid the warnings, we can discuss it later @amoghrajesh @eladkal :) |
amoghrajesh
reviewed
Jun 2, 2025
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
Good idea, i like it
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
…mmit (apache#51232)" (apache#51261) This reverts commit a8054bf.
jose-lehmkuhl
pushed a commit
to jose-lehmkuhl/airflow
that referenced
this pull request
Jul 11, 2025
…mmit (apache#51232)" (apache#51261) This reverts commit a8054bf.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…mmit (#51232)"
This reverts commit a8054bf.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.