Skip to content

Conversation

@kevinhongzl
Copy link
Contributor

closes: #51315

This PR improves the description of the task_instance_key_str template variable by removing the word "unique" for accuracy and adding some details.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@kevinhongzl kevinhongzl force-pushed the update-task_instance_key_str-description branch 8 times, most recently from 73e77b3 to 31e1146 Compare June 19, 2025 02:49
@kevinhongzl kevinhongzl force-pushed the update-task_instance_key_str-description branch 2 times, most recently from f0d5eec to fe62716 Compare June 25, 2025 07:06
@kevinhongzl kevinhongzl force-pushed the update-task_instance_key_str-description branch from fe62716 to 4d20e17 Compare June 30, 2025 15:52
@eladkal eladkal requested a review from uranusjr July 1, 2025 08:58
@kevinhongzl kevinhongzl force-pushed the update-task_instance_key_str-description branch from 4d20e17 to 9461461 Compare August 15, 2025 15:20
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added stale Stale PRs per the .github/workflows/stale.yml policy file and removed stale Stale PRs per the .github/workflows/stale.yml policy file labels Sep 30, 2025
Copy link
Contributor

@shahar1 shahar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we acknowledge the lack of uniqueness as an issue which is too complicated to be fixed this point, I would add somewhere in the document a clear warning that this key is not unique.

@shahar1
Copy link
Contributor

shahar1 commented Jan 30, 2026

Will be handled as part of #61258

@shahar1 shahar1 closed this Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

task_instance_key_str is misleadingly not unique

2 participants