Skip to content

Adding new contributor to G Adventures#5222

Merged
ashb merged 1 commit intoapache:masterfrom
tomwross:patch-1
May 1, 2019
Merged

Adding new contributor to G Adventures#5222
ashb merged 1 commit intoapache:masterfrom
tomwross:patch-1

Conversation

@tomwross
Copy link
Copy Markdown
Contributor

@tomwross tomwross commented May 1, 2019

G Adventures' Airflow-based project has a new contributor

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-XXX
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

No ticket, updating readme per general request

Description

  • Here are some details about my PR, including screenshots of any UI changes:

G Adventures' Airflow-based project has a new contributor, @chchtv11

image

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

No changes to code or functionality

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

No JIRA ticket, see above

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

No new functionality or changes to functionality that would require updating documentation

Code Quality

  • Passes flake8

G Adventures' Airflow-based project has a new contributor
@ashb ashb merged commit 6a70ed6 into apache:master May 1, 2019
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #5222 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5222      +/-   ##
==========================================
- Coverage   78.55%   78.54%   -0.01%     
==========================================
  Files         469      469              
  Lines       29983    29983              
==========================================
- Hits        23552    23551       -1     
- Misses       6431     6432       +1
Impacted Files Coverage Δ
airflow/models/taskinstance.py 92.42% <0%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ae15d8...a27c933. Read the comment docs.

andriisoldatenko pushed a commit to andriisoldatenko/airflow that referenced this pull request Jul 26, 2019
G Adventures' Airflow-based project has a new contributor

[ci skip]
wmorris75 pushed a commit to modmed-external/incubator-airflow that referenced this pull request Jul 29, 2019
G Adventures' Airflow-based project has a new contributor

[ci skip]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants