Provider Migration: Update azure for Airflow 3.0 compatibility#52618
Conversation
providers/microsoft/azure/src/airflow/providers/microsoft/azure/version_compat.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
60c467b to
6a46418
Compare
|
Test failures: https://github.com/apache/airflow/actions/runs/15992030386/job/45107520283?pr=52618#step:6:1117 |
|
@kaxil yeah, okay. Thank you. I will add testcode to pr. I have a question about task. I can not change In this case, I have to change test code? class SFTPToWasbOperator(BaseOperator):
......
def dry_run(self) -> None:
super().dry_run()
sftp_files: list[SftpFile] = self.get_sftp_files_map()
for file in sftp_files:
self.log.info(
"Process will upload file from (SFTP) %s to wasb://%s as %s",
file.sftp_file_path,
self.container_name,
file.blob_name,
)
if self.move_object:
self.log.info("Executing delete of %s", file)
I was trying to fix the test code. |
imo, we can remove the Or just add something like: def dry_run(self) -> None:
if not AIRFLOW_V_3_0_PLUS:
raise NotImplementedError("Not implemented for Airflow 3.")
super().dry_run()
sftp_files: list[SftpFile] = self.get_sftp_files_map()
for file in sftp_files:
self.log.info(
"Process will upload file from (SFTP) %s to wasb://%s as %s",
file.sftp_file_path,
self.container_name,
file.blob_name,
)
if self.move_object:
self.log.info("Executing delete of %s", file) |
fixup! fixup! ADD: type: ignore[no-redef]
|
Thank you, |
Good job! no worries - we all started one day ! |
Yeah, we all still learn new things everyday. Keep contributing. |


Follow-up of #52292. Part of #52378
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.