Fix KubernetesPodOperator loses connection to worker pod#52866
Closed
vmtuan12 wants to merge 2 commits intoapache:mainfrom
Closed
Fix KubernetesPodOperator loses connection to worker pod#52866vmtuan12 wants to merge 2 commits intoapache:mainfrom
vmtuan12 wants to merge 2 commits intoapache:mainfrom
Conversation
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
Sometimes, KubernetesPodOperator faces urllib3.exceptions.ProtocolError if the pod execution time is too long. Add wait and retry mechanism would fix this, after just 1 or 2 attempts.
vmtuan12
force-pushed
the
feature/fix-kubernetes-executor-pod-event
branch
from
35b5a05 to
9b4d842
Compare
Member
|
Yep. Adding test case would be good. |
vmtuan12
requested review from
ashb,
gopidesupavan,
jason810496 and
potiuk
as code owners
Contributor
Author
Thanks! I have added test |
Contributor
Author
|
This problem happens occasionally without a rule, so reproducing the exception is not really practicable, therefore adding a test for this is quite hard |
Member
You can mock it |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes, KubernetesOperator faces urllib3.exceptions.ProtocolError if the pod execution time is too long. Add wait and retry mechanism would fix this, after just 1 or 2 attempts. Detail has been discussed in #52865
Closes: #52865
Test evidence:
I have implemented a KubernetesPodOperator based on the original one, with wait & retry mechanism. And, it works like a charm
Before implementing wait & retry:
After implementing wait & retry:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.