[AIRFLOW-4524] Improve checkbox logic to restore functionality

[jmeickle]

Make sure you have checked all steps below.

Jira

• https://issues.apache.org/jira/browse/AIRFLOW-4524

Description

• Here are some details about my PR, including screenshots of any UI changes:

Tests

• My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

• My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
  1. Subject is separated from body by a blank line
  2. Subject is limited to 50 characters (not including Jira issue reference)
  3. Subject does not end with a period
  4. Subject uses the imperative mood ("add", not "adding")
  5. Body wraps at 72 characters
  6. Body explains "what" and "why", not "how"

Documentation

• In case of new functionality, my PR adds documentation that describes how to use it.
  • All the public functions and the classes in the PR contain docstrings that explain what it does
  • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

• Passes flake8

[codecov-io]

Codecov Report

Merging #5290 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #5290      +/-   ##
==========================================
+ Coverage   78.91%   78.91%   +<.01%     
==========================================
  Files         474      474              
  Lines       30046    30048       +2     
==========================================
+ Hits        23710    23712       +2     
  Misses       6336     6336

Impacted Files	Coverage Δ
airflow/www/views.py	76.22% <100%> (+0.03%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bc5607...5349671. Read the comment docs.

[jmeickle]

@ashb This doesn't completely fix the underlying issue (of reusing variable names within the same form and/or needing to split the form); but we do need this sort of helper function to properly read checkbox state. Is it OK to merge?

[ashb]

Looking at this now.

[ashb]

I think the issue was I messed up the cherry pick on to 1.10.3 as this only applies to the RBAC tree on v1-10-stable I think. Master just contains a single in put named "ingore_all_deps", as does the non-RBAC tree in 1.10.3.

In airflow/www_rbac/templates/airflow/dag.html I somehow added

            <input type="hidden" name="ignore_all_deps">
            <input type="hidden" name="ignore_ti_state">
            <input type="hidden" name="ignore_task_deps">

which doesn't exist on any other branch or commit. I have no idea where I got that from to commit it.

[ashb]

Closing in favour of #5378