Skip to content

AIRFLOW-4598 Task retries are not exhausted for K8s executor#5346

Closed
andy-g14 wants to merge 4 commits intoapache:masterfrom
andy-g14:AIRFLOW-4598
Closed

AIRFLOW-4598 Task retries are not exhausted for K8s executor#5346
andy-g14 wants to merge 4 commits intoapache:masterfrom
andy-g14:AIRFLOW-4598

Conversation

@andy-g14
Copy link
Contributor

@andy-g14 andy-g14 commented May 30, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following AIRFLOW-4598
    issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-XXX
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

When using K8s executor, If a task pod terminates with non zero code, the task is marked as failed, even though its retry count is not exhausted. The section of code I am removing is responsible for marking the task as failed. Adding the (task,state) to event_buffer should take care of retrying in the _process_executor_events method in the Scheduler.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@andy-g14
Copy link
Contributor Author

@dimberman

@andy-g14 andy-g14 closed this May 30, 2019
@andy-g14 andy-g14 deleted the AIRFLOW-4598 branch May 30, 2019 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant