AIRFLOW-4598 Task retries are not exhausted for K8s executor#5346
Closed
andy-g14 wants to merge 4 commits intoapache:masterfrom
Closed
AIRFLOW-4598 Task retries are not exhausted for K8s executor#5346andy-g14 wants to merge 4 commits intoapache:masterfrom
andy-g14 wants to merge 4 commits intoapache:masterfrom
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Jira
issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
Description
When using K8s executor, If a task pod terminates with non zero code, the task is marked as failed, even though its retry count is not exhausted. The section of code I am removing is responsible for marking the task as failed. Adding the (task,state) to event_buffer should take care of retrying in the _process_executor_events method in the Scheduler.
Tests
Commits
Documentation
Code Quality
flake8