Skip to content

Feat: Improve check translations script with Coverage and Completion metrics#53524

Merged
potiuk merged 1 commit intoapache:mainfrom
choo121600:dev-script
Jul 19, 2025
Merged

Feat: Improve check translations script with Coverage and Completion metrics#53524
potiuk merged 1 commit intoapache:mainfrom
choo121600:dev-script

Conversation

@choo121600
Copy link
Copy Markdown
Member

I think previous i18n check script's output confusing. When I saw the "All translations are complete and consistent!" message along with a 100% progress rate, even with many TODOs remaining, I mistakenly assumed that the translation was fully complete.

image

This PR enhances the script to provide a more accurate and nuanced status by introducing two distinct metrics:

  • Coverage: This would confirm that the key is synchronized between the en and the target language.
  • Completion: This would measure the actual translation progress by checking for keys that are no longer marked as TODO.
image image

closes: #53324


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

Copy link
Copy Markdown
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Tested it and works great :)

@potiuk potiuk merged commit fa60229 into apache:main Jul 19, 2025
104 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

Backport failed to create: v3-0-test. View the failure log Run details

Status Branch Result
v3-0-test Commit Link

You can attempt to backport this manually by running:

cherry_picker fa60229 v3-0-test

This should apply the commit to the v3-0-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

@choo121600 choo121600 deleted the dev-script branch July 19, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Translation completeness checker incorrectly shows 100% when TODO items exist

2 participants