Skip to content

bugfix(airflowctl): handle version command exception and make tests unified#53553

Merged
potiuk merged 3 commits intoapache:mainfrom
bugraoz93:bugfix/airflowctl/handle-version-connect-exception
Jul 20, 2025
Merged

bugfix(airflowctl): handle version command exception and make tests unified#53553
potiuk merged 3 commits intoapache:mainfrom
bugraoz93:bugfix/airflowctl/handle-version-connect-exception

Conversation

@bugraoz93
Copy link
Contributor

Exception handling for ctl version, while if the API is not reachable, it will fall back to only show ctl version along with the error returned from the client, which will make debugging easier for all.

Error fetching version information: [Errno 104] Connection reset by peer
{'airflowctl_version': '1.0.0'}

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good.

Though I'd propose to return a non-zero exit code on error of version. At the moment it is catched and just the print is adjusted.

@bugraoz93 bugraoz93 force-pushed the bugfix/airflowctl/handle-version-connect-exception branch from 4e6c5e9 to 0634a20 Compare July 20, 2025 18:43
@potiuk potiuk merged commit 0772b1e into apache:main Jul 20, 2025
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants