bugfix(airflowctl): handle version command exception and make tests unified#53553
Merged
potiuk merged 3 commits intoapache:mainfrom Jul 20, 2025
Merged
Conversation
jscheffl
approved these changes
Jul 20, 2025
Contributor
jscheffl
left a comment
There was a problem hiding this comment.
Look good.
Though I'd propose to return a non-zero exit code on error of version. At the moment it is catched and just the print is adjusted.
potiuk
approved these changes
Jul 20, 2025
4e6c5e9 to
0634a20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exception handling for ctl version, while if the API is not reachable, it will fall back to only show
ctlversion along with the error returned from the client, which will make debugging easier for all.Error fetching version information: [Errno 104] Connection reset by peer {'airflowctl_version': '1.0.0'}^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.