Skip to content

[AIRFLOW-4753] Utils log json formatter#5393

Merged
BasPH merged 1 commit intoapache:masterfrom
PolideaInternal:utils-log-json-formatter
Jun 9, 2019
Merged

[AIRFLOW-4753] Utils log json formatter#5393
BasPH merged 1 commit intoapache:masterfrom
PolideaInternal:utils-log-json-formatter

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Jun 9, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-4753
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    Fixes pylint for the formatter.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    No tests.

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@potiuk potiuk requested a review from BasPH June 9, 2019 09:45
@potiuk potiuk changed the title Utils log json formatter [AIRFLOW=4753] Utils log json formatter Jun 9, 2019
@potiuk potiuk changed the title [AIRFLOW=4753] Utils log json formatter [AIRFLOW-4753] Utils log json formatter Jun 9, 2019
@codecov-io
Copy link

codecov-io commented Jun 9, 2019

Codecov Report

Merging #5393 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5393      +/-   ##
==========================================
+ Coverage   79.02%   79.02%   +<.01%     
==========================================
  Files         481      481              
  Lines       30203    30203              
==========================================
+ Hits        23868    23869       +1     
+ Misses       6335     6334       -1
Impacted Files Coverage Δ
airflow/utils/log/json_formatter.py 100% <100%> (ø) ⬆️
airflow/models/taskinstance.py 92.61% <0%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e99121...60b32c6. Read the comment docs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nit: to keep ! -name 'webserver_config.py' consistent with the other code, would use -not:

-not -name 'webserver_config.py'

@BasPH
Copy link
Contributor

BasPH commented Jun 9, 2019

This PR contains 2 commits, one should be for your other PR

@potiuk potiuk force-pushed the utils-log-json-formatter branch from 0c63d9e to 60b32c6 Compare June 9, 2019 14:04
@potiuk
Copy link
Member Author

potiuk commented Jun 9, 2019

Yep. It was based on the previous change. I rebased it on master now.

@potiuk
Copy link
Member Author

potiuk commented Jun 9, 2019

Should be ok now @BasPH

@BasPH BasPH merged commit 2fd7567 into apache:master Jun 9, 2019
andriisoldatenko pushed a commit to andriisoldatenko/airflow that referenced this pull request Jul 26, 2019
wmorris75 pushed a commit to modmed-external/incubator-airflow that referenced this pull request Jul 29, 2019
@potiuk potiuk deleted the utils-log-json-formatter branch September 19, 2019 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants