[AIRFLOW-4753] Utils log json formatter#5393
Merged
BasPH merged 1 commit intoapache:masterfrom Jun 9, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5393 +/- ##
==========================================
+ Coverage 79.02% 79.02% +<.01%
==========================================
Files 481 481
Lines 30203 30203
==========================================
+ Hits 23868 23869 +1
+ Misses 6335 6334 -1
Continue to review full report at Codecov.
|
BasPH
reviewed
Jun 9, 2019
scripts/ci/ci_pylint.sh
Outdated
Contributor
There was a problem hiding this comment.
Tiny nit: to keep ! -name 'webserver_config.py' consistent with the other code, would use -not:
-not -name 'webserver_config.py'
Contributor
|
This PR contains 2 commits, one should be for your other PR |
6 tasks
0c63d9e to
60b32c6
Compare
Member
Author
|
Yep. It was based on the previous change. I rebased it on master now. |
Member
Author
|
Should be ok now @BasPH |
BasPH
approved these changes
Jun 9, 2019
andriisoldatenko
pushed a commit
to andriisoldatenko/airflow
that referenced
this pull request
Jul 26, 2019
wmorris75
pushed a commit
to modmed-external/incubator-airflow
that referenced
this pull request
Jul 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Jira
Description
Fixes pylint for the formatter.
Tests
No tests.
Commits
Documentation
Code Quality
flake8