Skip to content

[AIRFLOW-4754] Fixed failure when no .git repo is found#5396

Merged
BasPH merged 1 commit intoapache:masterfrom
PolideaInternal:fix-setup-py-git-exception
Jun 9, 2019
Merged

[AIRFLOW-4754] Fixed failure when no .git repo is found#5396
BasPH merged 1 commit intoapache:masterfrom
PolideaInternal:fix-setup-py-git-exception

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Jun 9, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-4754
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@potiuk potiuk requested a review from BasPH June 9, 2019 17:45
@potiuk
Copy link
Member Author

potiuk commented Jun 9, 2019

Hey @BasPH - the last commit with pylint for setup.py broke builds when no .git repo is checked out (which is the case for docker image build in DockerHub). This commit should fix it.

@codecov-io
Copy link

codecov-io commented Jun 9, 2019

Codecov Report

Merging #5396 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5396   +/-   ##
=======================================
  Coverage   79.03%   79.03%           
=======================================
  Files         481      481           
  Lines       30215    30215           
=======================================
  Hits        23879    23879           
  Misses       6336     6336

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dd3f31...dc1789d. Read the comment docs.

@potiuk
Copy link
Member Author

potiuk commented Jun 9, 2019

@BasPH -> i need that one to check that the dockerfile builds as needed on DockerHub.

@BasPH
Copy link
Contributor

BasPH commented Jun 9, 2019

Whoops, thanks for the fix!

@BasPH BasPH merged commit 54d41df into apache:master Jun 9, 2019
andriisoldatenko pushed a commit to andriisoldatenko/airflow that referenced this pull request Jul 26, 2019
wmorris75 pushed a commit to modmed-external/incubator-airflow that referenced this pull request Jul 29, 2019
@potiuk potiuk deleted the fix-setup-py-git-exception branch September 19, 2019 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants