[AIRFLOW-4754] Fixed failure when no .git repo is found#5396
Merged
BasPH merged 1 commit intoapache:masterfrom Jun 9, 2019
Merged
[AIRFLOW-4754] Fixed failure when no .git repo is found#5396BasPH merged 1 commit intoapache:masterfrom
BasPH merged 1 commit intoapache:masterfrom
Conversation
Member
Author
|
Hey @BasPH - the last commit with pylint for setup.py broke builds when no .git repo is checked out (which is the case for docker image build in DockerHub). This commit should fix it. |
Codecov Report
@@ Coverage Diff @@
## master #5396 +/- ##
=======================================
Coverage 79.03% 79.03%
=======================================
Files 481 481
Lines 30215 30215
=======================================
Hits 23879 23879
Misses 6336 6336Continue to review full report at Codecov.
|
Member
Author
|
@BasPH -> i need that one to check that the dockerfile builds as needed on DockerHub. |
Contributor
|
Whoops, thanks for the fix! |
BasPH
approved these changes
Jun 9, 2019
andriisoldatenko
pushed a commit
to andriisoldatenko/airflow
that referenced
this pull request
Jul 26, 2019
wmorris75
pushed a commit
to modmed-external/incubator-airflow
that referenced
this pull request
Jul 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Jira
Description
Tests
Commits
Documentation
Code Quality
flake8