Skip to content

Comments

[AIRFLOW-5409] Added name under Who uses Apache Airflow for tracking purpose.#5409

Merged
feng-tao merged 3 commits intoapache:masterfrom
hiteshrd:master
Jun 13, 2019
Merged

[AIRFLOW-5409] Added name under Who uses Apache Airflow for tracking purpose.#5409
feng-tao merged 3 commits intoapache:masterfrom
hiteshrd:master

Conversation

@hiteshrd
Copy link
Contributor

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-XXX
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • [x ] Here are some details about my PR, including screenshots of any UI changes:
    Added name under Who uses Apache Airflow for tracking purpose.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@codecov-io
Copy link

codecov-io commented Jun 12, 2019

Codecov Report

Merging #5409 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5409      +/-   ##
==========================================
- Coverage   79.08%   79.07%   -0.01%     
==========================================
  Files         483      483              
  Lines       30284    30284              
==========================================
- Hits        23949    23948       -1     
- Misses       6335     6336       +1
Impacted Files Coverage Δ
airflow/models/taskinstance.py 93.02% <0%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34056f8...6a6ea7b. Read the comment docs.

@feng-tao
Copy link
Member

could you:

  1. append [AIRFLOW-XXX] in your commit/pr title
  2. put your entry in alphabetical order

Corrected Sequence in who uses airflow section
@hiteshrd hiteshrd changed the title Added name under Who uses Apache Airflow for tracking purpose. [AIRFLOW-5409] Added name under Who uses Apache Airflow for tracking purpose. Jun 12, 2019
@hiteshrd
Copy link
Contributor Author

@feng-tao

  1. Updated pr title.
  2. Added Entry in alphabetical order.

@feng-tao feng-tao merged commit d94197d into apache:master Jun 13, 2019
andriisoldatenko pushed a commit to andriisoldatenko/airflow that referenced this pull request Jul 26, 2019
…purpose. (apache#5409)

* Update README.md

* Corrected Sequence

Corrected Sequence in who uses airflow section
wmorris75 pushed a commit to modmed-external/incubator-airflow that referenced this pull request Jul 29, 2019
…purpose. (apache#5409)

* Update README.md

* Corrected Sequence

Corrected Sequence in who uses airflow section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants