[AIRFLOW-4782] Make GCP hooks Pylint compatible#5431
Conversation
| """ | ||
| Interact with Google Cloud KMS. This hook uses the Google Cloud Platform | ||
| connection. | ||
|
|
There was a problem hiding this comment.
It seems to me that this is not true, because no method in this class needs project_id
| class PubSubException(Exception): | ||
| pass | ||
| # Alias for Exception | ||
| PubSubException = Exception |
There was a problem hiding this comment.
It seems to me that it changes the behavior of the code. What error is it related to?
There was a problem hiding this comment.
Unnecessary pass statement but this could be solved by leaving a docstring instead of bare pass.
| @cached_property | ||
| def annotator_client(self): | ||
| """ | ||
| Creates ImageAnnotatorClient. |
There was a problem hiding this comment.
| Creates ImageAnnotatorClient. | |
| Creates ImageAnnotatorClient. | |
Empty line is required after description.
Codecov Report
@@ Coverage Diff @@
## master #5431 +/- ##
=========================================
Coverage ? 79.12%
=========================================
Files ? 488
Lines ? 30665
Branches ? 0
=========================================
Hits ? 24263
Misses ? 6402
Partials ? 0
Continue to review full report at Codecov.
|
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
Please take a look if we can get rid of the "no-member" by annotating get_conn() return type
4 participants
Make sure you have checked all steps below.
Jira
Description
Code Quality
flake8